support named properties in EBMC/ic3 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EBMC/ic3 used the hypothesis that properties are numbered, not named. This removes this constraint by comparing the index of the property in `ic3_enginet` / `CompInfo` to the index in the property list. This also adds a regression test that uses named properties.
mgudemann
force-pushed
the
fix/named_properties_ebmc_ic3
branch
from
a4d5a04 to
b07902d
Compare
|
Hi Matthias,
I approved your second pull request. Do you get automatic updates from
GitHub
in case something changes with your pull requests?
If so, I will not be informing you about my actions :-)
Eugene
…On Wed, May 3, 2017 at 4:59 AM, Matthias Güdemann ***@***.***> wrote:
EBMC/ic3 used the hypothesis that properties are numbered, not named. This
removes this constraint by comparing the index of the property in
ic3_enginet
/ CompInfo to the index in the property list.
This also adds a regression test that uses named properties.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- support named properties in EBMC/ic3
File Changes
- *A* regression/ebmc/ic3/non_inductive1/non_inductive.sv
<https://github.com/diffblue/hw-cbmc/pull/2/files#diff-0> (39)
- *A* regression/ebmc/ic3/non_inductive1/test.desc
<https://github.com/diffblue/hw-cbmc/pull/2/files#diff-1> (6)
- *M* src/ic3/r6ead_input.cc
<https://github.com/diffblue/hw-cbmc/pull/2/files#diff-2> (17)
Patch Links:
- https://github.com/diffblue/hw-cbmc/pull/2.patch
- https://github.com/diffblue/hw-cbmc/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AS5pCrjLPPaR0B4ASqonAN2xcbfmSKhnks5r2EH8gaJpZM4NPHwi>
.
|
|
Hi Eugene, yes, I get a notification. github is quite chatty in this regard :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EBMC/ic3 used the hypothesis that properties are numbered, not named. This
removes this constraint by comparing the index of the property in
ic3_enginet/
CompInfoto the index in the property list.This also adds a regression test that uses named properties.