Extend simplification of extractbits #7343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tautschnig
added
blocker
Kani
Codecov ReportBase: 78.35% // Head: 78.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7343 +/- ##
========================================
Coverage 78.35% 78.36%
========================================
Files 1645 1645
Lines 190208 190248 +40
========================================
+ Hits 149040 149081 +41
+ Misses 41168 41167 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
changed the title
3 tasks
|
@TGWDB Can someone from the DiffBlue SMT team give this a first review to smooth the way for Daniel and/or Peter? |
tautschnig
force-pushed
the
feature/simp-extractbits
branch
from
81b6b69 to
9207527
Compare
jimgrundy
reviewed
Nov 23, 2022
tautschnig
force-pushed
the
feature/simp-extractbits
branch
from
9207527 to
21cb9d0
Compare
Simplify nested extractbits expressions, simplify more cases of extractbits-out-of-concatenation, simplify concatenation of back-to-back extractbits.
tautschnig
force-pushed
the
feature/simp-extractbits
branch
from
21cb9d0 to
eaea3ae
Compare
kroening
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify nested extractbits expressions, simplify more cases of extractbits-out-of-concatenation, simplify concatenation of back-to-back extractbits.
There is no hard dependency on #7340, but the code might not be exercised without those changes.Edit: codecov reporting suggests that indeed we do already cover the newly introduced branches.