-
Notifications
You must be signed in to change notification settings - Fork 274
Simplify byte extract: use lowering when expression is a constant #7340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify byte extract: use lowering when expression is a constant #7340
Conversation
@tautschnig #7331 got merged, so this PR should be ready for a rebase before going through review. |
We must not end up with single-element concatenation that has a type different from its operand. Observed on Pointer_byte_extract8 once enabling further simplification of byte extract.
f746c86
to
f91f60a
Compare
When none of the earlier simplification rules apply, rewrite the expression to to apply simplification rules for arithmetic and logic expressions.
f91f60a
to
7c2fa6f
Compare
Codecov ReportBase: 78.37% // Head: 78.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7340 +/- ##
===========================================
+ Coverage 78.37% 78.39% +0.01%
===========================================
Files 1647 1647
Lines 190328 190362 +34
===========================================
+ Hits 149172 149226 +54
+ Misses 41156 41136 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
When none of the earlier simplification rules apply, rewrite the expression to to apply simplification rules for arithmetic and logic expressions.