Skip to content

Simplify typecast over ID_bv and pointers #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

tautschnig
Copy link
Collaborator

This has the same semantics as ID_signedbv or ID_unsignedbv.

There is no hard dependency on #7343, but the code might not be exercised without those changes.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 13, 2022
@tautschnig tautschnig added the Kani Bugs or features of importance to Kani Rust Verifier label Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 78.35% // Head: 78.36% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f319e79) compared to base (25c32cc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7344   +/-   ##
========================================
  Coverage    78.35%   78.36%           
========================================
  Files         1645     1645           
  Lines       190208   190250   +42     
========================================
+ Hits        149040   149083   +43     
+ Misses       41168    41167    -1     
Impacted Files Coverage Δ
src/util/simplify_expr.cpp 85.31% <100.00%> (+0.01%) ⬆️
src/util/simplify_expr_int.cpp 87.69% <100.00%> (+0.53%) ⬆️
src/util/bitvector_expr.h 97.41% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This has the same semantics as ID_signedbv or ID_unsignedbv.
@tautschnig tautschnig marked this pull request as ready for review November 25, 2022 15:37
@tautschnig tautschnig changed the title Simplify typecast over ID_bv and pointers [depends-on: #7343] Simplify typecast over ID_bv and pointers Nov 25, 2022
@peterschrammel peterschrammel removed their assignment Nov 25, 2022
@tautschnig tautschnig merged commit 21574de into diffblue:develop Nov 25, 2022
@tautschnig tautschnig deleted the feature/simp-tc-bv branch November 25, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kani Bugs or features of importance to Kani Rust Verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants