Permit initializers in library functions #6590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 78.41% // Head: 78.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6590 +/- ##
===========================================
- Coverage 78.41% 78.39% -0.03%
===========================================
Files 1655 1655
Lines 190264 190281 +17
===========================================
- Hits 149201 149172 -29
- Misses 41063 41109 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
force-pushed
the
link-library-functions
branch
5 times, most recently
from
c3f5f03 to
ad72b1e
Compare
tautschnig
requested review from
chrisr-diffblue,
kroening and
peterschrammel
as code owners
tautschnig
force-pushed
the
link-library-functions
branch
from
ad72b1e to
a52875a
Compare
4 tasks
chrisr-diffblue
approved these changes
Jan 22, 2022
tautschnig
force-pushed
the
link-library-functions
branch
from
a52875a to
236b6ef
Compare
tautschnig
force-pushed
the
link-library-functions
branch
3 times, most recently
from
d544bb6 to
10bec57
Compare
chris-ryder
approved these changes
Feb 8, 2022
3 tasks
tautschnig
force-pushed
the
link-library-functions
branch
from
10bec57 to
e0d8e54
Compare
tautschnig
force-pushed
the
link-library-functions
branch
from
e0d8e54 to
1643bed
Compare
Comment on lines
+119
to
+127
| { | ||
| changed = true; | ||
| added_functions.insert(id); | ||
|
|
There was a problem hiding this comment.
How about reformulating the control flow structure as
if(body_available || already_added)
continue;
// add the symbol
changed = true;
added_functions.insert(id);
...
There was a problem hiding this comment.
Could do, but then I'd have to touch more code in this PR.
tautschnig
changed the title
tautschnig
changed the title
tautschnig
force-pushed
the
link-library-functions
branch
from
a9db9b9 to
4572567
Compare
tautschnig
force-pushed
the
link-library-functions
branch
from
4572567 to
42ddaab
Compare
peterschrammel
approved these changes
Dec 8, 2022
MSVC won't have the built-in declarations available, and will thus fail type checking.
The test descriptions expect valid enum values, which we didn't actually have any guarantee built into the test for.
This enables type checking of missing functions vs library-provided functions, and also enables type sanitisation as done by the linker. Co-authored-by: Peter Schrammel <[email protected]>
With the support of building initialisers while adding the library we can move library-only symbols to the library. This avoids polluting the initialisation function for all cases that don't actually use pipe-related library functions.
With the support of building initialisers while adding the library we can move library-only symbols to the library. This avoids polluting the initialisation function for all cases that don't actually use memory (de-)allocation library functions.
With the support of building initialisers while adding the library we can move library-only symbols to the library. This avoids polluting the initialisation function for all cases that don't actually use pthreads-related library functions. This removal of unused symbols required adding a symbol into the array_of_bool_as_bitvec test, which previously implicitly relied on those library-specific symbols in the patterns being tested for.
tautschnig
force-pushed
the
link-library-functions
branch
from
42ddaab to
d849c8f
Compare
7 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 12, 2022
With diffblue#6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.
4 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 13, 2022
With diffblue#6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 13, 2022
With diffblue#6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 14, 2022
With diffblue#6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 14, 2022
With diffblue#6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this series of commits is to reduce the number of
__CPROVER_...static-lifetime objects that appear in every program irrespective of their use by C (model) library functions. This will limit verification overhead to those cases where they are actually used. This will also enable more costly objects (such as unbounded arrays) to be used by future library instrumentation.