Incremental SMT back-end no longer requires --slice-formula #7432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
peterschrammel,
thomasspriggs,
NlightNFotis,
TGWDB and
chris-ryder
as code owners
tautschnig
force-pushed
the
cleanup/smt-incr
branch
from
5786199 to
3adaa2b
Compare
peterschrammel
approved these changes
Dec 13, 2022
tautschnig
force-pushed
the
cleanup/smt-incr
branch
from
3adaa2b to
8286270
Compare
tautschnig
force-pushed
the
cleanup/smt-incr
branch
from
8286270 to
f525071
Compare
7 tasks
With diffblue#6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.
tautschnig
force-pushed
the
cleanup/smt-incr
branch
from
f525071 to
f89db31
Compare
Codecov ReportBase: 78.40% // Head: 78.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7432 +/- ##
===========================================
- Coverage 78.40% 78.40% -0.01%
===========================================
Files 1659 1659
Lines 190383 190381 -2
===========================================
- Hits 149276 149274 -2
Misses 41107 41107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #6590, several unnecessary symbols are no longer included in goto programs. These include unbounded arrays, which the incremental SMT back-end hitherto does not support. The use of --slice-formula was a workaround to make sure the unnecessary symbols (or equalities over them) don't end up in the formula; now they aren't part of the goto program, so the workaround no longer adds value.