Skip to content

Replace __CPROVER_malloc_is_new_array by an uninterpreted function #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tautschnig
Copy link
Collaborator

With this encoding we no longer non-deterministically track just one
such array. This enables the use in assumptions. Also, we will only
incur a cost in the encoding when actually using new/delete instead of
always having a global variable, even when unused.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Its use was deprecated since 2021-05-06. The only remaining need for
tracking this object is to distinguish new vs new[] (and delete vs
delete[]). This specific case is now handled via __CPROVER_new_object.
With this encoding we no longer non-deterministically track just one
such array. This enables the use in assumptions. Also, we will only
incur a cost in the encoding when actually using new/delete instead of
always having a global variable, even when unused.
@tautschnig tautschnig force-pushed the malloc-is-new-uninterpreted branch from 4b0a5c2 to 911de16 Compare November 18, 2021 20:57
@tautschnig tautschnig changed the title Replace __CPROVER_malloc_is_new_array by an uninterpreted function [depends on #6094] Replace __CPROVER_malloc_is_new_array by an uninterpreted function Dec 1, 2021
@tautschnig
Copy link
Collaborator Author

Closing as there are other PRs that more properly yield the desired improvements: #6506 introduces (unbounded) arrays, and #6590 ensures there only is a cost when the symbol is really used.

@tautschnig tautschnig closed this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant