cfgt: introduce and use a public interface when interacting with the entry map [blocks: 5049, 5059] #5051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
danpoe,
hannes-steffenhagen-diffblue,
kroening,
martin-cs,
NathanJPhillips,
owen-mc-diffblue,
peterschrammel,
pkesseli,
tautschnig and
thk123
as code owners
smowton
force-pushed
the
smowton/cleanup/cfg-interface
branch
from
6f006de to
387932e
Compare
This was referenced Aug 22, 2019
smowton
force-pushed
the
smowton/cleanup/cfg-interface
branch
from
387932e to
8460a02
Compare
peterschrammel
changed the title
peterschrammel
changed the title
peterschrammel
changed the title
smowton
force-pushed
the
smowton/cleanup/cfg-interface
branch
from
8460a02 to
afb2a95
Compare
smowton
changed the title
…entry map This eliminates many uses of the cfg[cfg.entry_map[instruction]] pattern, and makes it easier to refactor / change the implementation of cfgt.
smowton
force-pushed
the
smowton/cleanup/cfg-interface
branch
from
afb2a95 to
9b0133d
Compare
allredj
reviewed
Aug 23, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9b0133d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124431732
Codecov Report
@@ Coverage Diff @@
## develop #5051 +/- ##
===========================================
- Coverage 69.57% 69.57% -0.01%
===========================================
Files 1314 1314
Lines 108913 108898 -15
===========================================
- Hits 75773 75762 -11
+ Misses 33140 33136 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates many uses of the
cfg[cfg.entry_map[instruction]]pattern, and makes it easier to refactor / change the implementation of cfgt. No behavioural changes intended. Depends on #5045 -- don't review the first commit.