Add public interface for natural_loopst and natural_loopt #5059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
danpoe,
hannes-steffenhagen-diffblue,
kroening,
martin-cs,
NathanJPhillips,
owen-mc-diffblue,
peterschrammel,
pkesseli,
tautschnig and
thk123
as code owners
|
|
||
| public: | ||
| typedef std::set<T> loop_instructionst; | ||
| loop_instructionst loop_instructions; |
There was a problem hiding this comment.
Doh, fixed it now, and made these private as you say.
peterschrammel
changed the title
smowton
force-pushed
the
smowton/cleanup/natural-loops-interface
branch
5 times, most recently
from
d6ce8c3 to
0e7a98a
Compare
smowton
changed the title
smowton
force-pushed
the
smowton/cleanup/natural-loops-interface
branch
from
0e7a98a to
ec607df
Compare
This hides the implementation of natural_loopt, making it easier to change in future. No behavioural change intended.
smowton
force-pushed
the
smowton/cleanup/natural-loops-interface
branch
from
ec607df to
ec02d14
Compare
allredj
reviewed
Aug 26, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: ec02d14).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124559280
|
@peterschrammel now passing, please re-review |
kroening
approved these changes
Aug 26, 2019
peterschrammel
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to alter the implementation of these types. No behavioural change intended. Depends on #5051; do not review the first two commits.