Skip to content

cfg_dominatorst: introduce a public interface [blocks: 5051] #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Aug 22, 2019

This eliminates most use of cfg_dominatorst::cfg, hiding the implementation behind a clean interface. No behavioural changes.

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo documenting the interface.

This eliminates most use of cfg_dominatorst::cfg, hiding the implementation behind a clean interface.
@smowton smowton force-pushed the smowton/cleanup/cfg-dominators-interface branch from f7ca671 to 9620ae6 Compare August 23, 2019 15:33
@peterschrammel peterschrammel changed the title cfg_dominatorst: introduce a public interface cfg_dominatorst: introduce a public interface [blocks: 5051] Aug 23, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 9620ae6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124405489

@smowton smowton merged commit 82d0ea2 into diffblue:develop Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants