Object factory: ensure generated assignments are exactly type-consistent [blocks: #3966] #4126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the initialiser could have a followed (e.g. struct) type, while the LHS being set up could have a tag type.
At the moment --validate-goto-model doesn't give this strong a guarantee, but at least within the object factory we should only be producing exactly type-consistent statements.
smowton
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli and
thk123
as code owners
tautschnig
approved these changes
Feb 8, 2019
tautschnig
changed the title
|
Just noting here that these fixes are actually required to make #3966 mergeable (as otherwise a test fails). |
allredj
reviewed
Feb 8, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 814426b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100219870
kroening
approved these changes
Feb 8, 2019
|
@tautschnig looks like neither one is superseded, they do independent cleanups around the same area. |
|
Manual bump: diffblue/test-gen#3027 (awaiting CI) |
thk123
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.