-
Notifications
You must be signed in to change notification settings - Fork 274
Reinstate limited symex renaming [blocks: #4164] #3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate limited symex renaming [blocks: #4164] #3966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 39891fa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98742295
39891fa
to
d060bd8
Compare
d060bd8
to
e2ddce8
Compare
…erve-exact-type Object factory: ensure generated assignments are exactly type-consistent [blocks: #3966]
e2ddce8
to
12c189a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 12c189a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100270085
@thk123 @allredj @tautschnig good news, I've got a test-gen bump (https://github.com/diffblue/test-gen/tree/smowton/wip/bump-disable-renaming-fix-object-factory) that brings this in, accompanied by some object factory type consistency improvements (CBMC working branch: https://github.com/smowton/cbmc/tree/smowton/wip/verify-members-and-limited-renaming-and-object-factory-fixes). I'm now trying to find a reasonable order to get the parts of that into cbmc. |
@tautschnig now that #4161 is in, let's do this! |
12c189a
to
94dacc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 94dacc5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100611949
This is a clean revert of #3947, which in turn was a revert of the symex renaming improvements for TG's benefit. All changes in this PR have previously been approved, it is now up to TG maintainers to confirm that any issues have been fixed.