Skip to content

Reinstate limited symex renaming [blocks: #4164] #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2019

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jan 27, 2019

This is a clean revert of #3947, which in turn was a revert of the symex renaming improvements for TG's benefit. All changes in this PR have previously been approved, it is now up to TG maintainers to confirm that any issues have been fixed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 39891fa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98742295

@tautschnig tautschnig force-pushed the reinstate-limited-symex-renaming branch from 39891fa to d060bd8 Compare February 5, 2019 09:51
@tautschnig tautschnig changed the title Reinstate limited symex renaming Reinstate limited symex renaming [depends-on: #4126] Feb 8, 2019
@tautschnig tautschnig force-pushed the reinstate-limited-symex-renaming branch from d060bd8 to e2ddce8 Compare February 8, 2019 11:28
@tautschnig tautschnig changed the title Reinstate limited symex renaming [depends-on: #4126] Reinstate limited symex renaming Feb 8, 2019
tautschnig added a commit that referenced this pull request Feb 8, 2019
…erve-exact-type

Object factory: ensure generated assignments are exactly type-consistent [blocks: #3966]
@tautschnig tautschnig force-pushed the reinstate-limited-symex-renaming branch from e2ddce8 to 12c189a Compare February 8, 2019 16:14
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 12c189a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100270085

@smowton
Copy link
Contributor

smowton commented Feb 11, 2019

@thk123 @allredj @tautschnig good news, I've got a test-gen bump (https://github.com/diffblue/test-gen/tree/smowton/wip/bump-disable-renaming-fix-object-factory) that brings this in, accompanied by some object factory type consistency improvements (CBMC working branch: https://github.com/smowton/cbmc/tree/smowton/wip/verify-members-and-limited-renaming-and-object-factory-fixes). I'm now trying to find a reasonable order to get the parts of that into cbmc.

@tautschnig tautschnig changed the title Reinstate limited symex renaming Reinstate limited symex renaming [blocks: #4164] Feb 12, 2019
@smowton
Copy link
Contributor

smowton commented Feb 12, 2019

@tautschnig now that #4161 is in, let's do this!

@tautschnig tautschnig assigned tautschnig and unassigned kroening Feb 12, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 94dacc5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100611949

@smowton smowton merged commit b43753a into diffblue:develop Feb 12, 2019
@tautschnig tautschnig deleted the reinstate-limited-symex-renaming branch February 12, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants