Skip to content

Revert symex renaming #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2019

Conversation

tautschnig
Copy link
Collaborator

This is just a temporary measure to help TG get back on track. As soon as the problems in TG have been sorted out this PR should again be reverted to bring back the improvements in symex renaming.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the revert-symex-renaming branch from 103ab0d to 7298a10 Compare January 25, 2019 12:57
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch(diff^-1, patch(diff, x)) == x,
but CI(x, patch(diff, x)) != CI(patch(diff, x), patch(diff^-1, patch(diff, x))) ;)

@allredj
Copy link
Contributor

allredj commented Jan 25, 2019

@tautschnig
Copy link
Collaborator Author

CI(x, patch(diff, x)) != CI(patch(diff, x), patch(diff^-1, patch(diff, x))) ;)

Because clang-format(diff) != clang-format(diff^-1) ... ;-)

I'll add a clang-format patch, which should then equally be reverted.

@tautschnig tautschnig force-pushed the revert-symex-renaming branch from 7298a10 to 60ce997 Compare January 25, 2019 15:26
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 60ce997).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98632766
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for TG CI, but LGTM

@allredj
Copy link
Contributor

allredj commented Jan 25, 2019

TG bump is passing.

@peterschrammel peterschrammel merged commit 6b51aeb into diffblue:develop Jan 25, 2019
@tautschnig tautschnig deleted the revert-symex-renaming branch February 27, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants