-
Notifications
You must be signed in to change notification settings - Fork 274
Revert symex renaming #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert symex renaming #3947
Conversation
This reverts commit 0e01c89.
103ab0d
to
7298a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch(diff^-1, patch(diff, x)) == x,
but CI(x, patch(diff, x)) != CI(patch(diff, x), patch(diff^-1, patch(diff, x))) ;)
Because clang-format(diff) != clang-format(diff^-1) ... ;-) I'll add a clang-format patch, which should then equally be reverted. |
7298a10
to
60ce997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 60ce997).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98632766
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting for TG CI, but LGTM
TG bump is passing. |
This is just a temporary measure to help TG get back on track. As soon as the problems in TG have been sorted out this PR should again be reverted to bring back the improvements in symex renaming.