Skip to content

Fixes to the byte_operator lowering unit test [blocks: #2068, #4062, #4063] #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

tautschnig
Copy link
Collaborator

Let's only test byte extracts within bounds for now (there is ample work to be
done to get those right), but make sure there is possible combination for each
pair of types. Endianness needs to be taken into account when constructing the
expected value. Disable any non-POD tests as they all need more work.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f1795cb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99573209

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: a8c5ee0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99647141

Let's only test byte extracts within bounds for now (there is ample work to be
done to get those right), but make sure there is possible combination for each
pair of types. Endianness needs to be taken into account when constructing the
expected value. Disable any non-POD tests as they all need more work.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 2467571).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99708859

@tautschnig tautschnig changed the title Fixes to the byte_operator lowering unit test [blocks: #2068] Fixes to the byte_operator lowering unit test [blocks: #2068, #4062, #4063] Feb 5, 2019
@kroening kroening merged commit 5a2df0d into diffblue:develop Feb 6, 2019
@tautschnig tautschnig deleted the byte-op-unit-test-2 branch February 7, 2019 07:49
tautschnig added a commit that referenced this pull request Feb 7, 2019
byte_extract lowering: lower newly introduced byte_extract expressions [depends-on: #4061, blocks: #2068]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants