byte_extract lowering: ensure type consistency [blocks: #2068] #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
peterschrammel and
smowton
as code owners
tautschnig
assigned smowton, kroening, peterschrammel and chrisr-diffblue and unassigned tautschnig
smowton
approved these changes
Feb 7, 2019
tautschnig
changed the title
3 tasks
allredj
reviewed
Feb 7, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: dab949a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100131306
tautschnig
added a commit
that referenced
this pull request
Feb 14, 2019
Cleanup of SMT2 solver test execution and CMake support [blocks: #4063]
Make sure we construct concatenations that are type consistent.
… conversion Most of those shouldn't even be happening as more support needs to be implemented in byte_extract_lowering. Will be taken care of in follow-up commits.
tautschnig
force-pushed
the
byte-op-2
branch
from
dab949a to
8c154e2
Compare
tautschnig
changed the title
allredj
reviewed
Feb 14, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 8c154e2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100895849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the second commit is new, the first one is #4061.