byte_extract lowering: lower newly introduced byte_extract expressions [depends-on: #4061, blocks: #2068] #4062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
peterschrammel and
smowton
as code owners
smowton
approved these changes
Feb 4, 2019
| @@ -154,8 +154,7 @@ SCENARIO("byte_extract_lowering", "[core][solvers][lowering][byte_extract]") | |||
| const exprt lower_be = lower_byte_extract(be, ns); | |||
| const exprt lower_be_s = simplify_expr(lower_be, ns); | |||
|
|
|||
| // TODO: does not currently hold | |||
| // REQUIRE(!has_subexpr(lower_be, ID_byte_extract_little_endian)); | |||
| REQUIRE(!has_subexpr(lower_be, ID_byte_extract_little_endian)); | |||
There was a problem hiding this comment.
Presumably also big_endian?
There was a problem hiding this comment.
Ah, indeed, actually that should be fixed in the first commit (which is #4061).
tautschnig
force-pushed
the
byte-op-1
branch
2 times, most recently
from
f6e617d to
36385be
Compare
allredj
reviewed
Feb 5, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 36385be).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99858855
allredj
reviewed
Feb 7, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: bae5803).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100049738
byte_extract lowering must not return any further byte_extract expressions.
allredj
reviewed
Feb 7, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 1f94bce).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100077409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the second commit is new, the first one is #4061.