Use goto_programt::make_X factories in remove_returns #4001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jan 31, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
kroening
changed the title
tautschnig
requested changes
Jan 31, 2019
smowton
approved these changes
Jan 31, 2019
kroening
requested review from
chrisr-diffblue,
martin-cs and
thk123
as code owners
kroening
force-pushed
the
use_make_X2
branch
3 times, most recently
from
aa29b37 to
2901242
Compare
kroening
force-pushed
the
use_make_X2
branch
from
2901242 to
432ade2
Compare
kroening
requested review from
danpoe and
hannes-steffenhagen-diffblue
as code owners
allredj
reviewed
Feb 10, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 432ade2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100357517
3 tasks
added 2 commits
February 10, 2019 12:11
…ction This avoids duplicate initialization of the inserted instruction.
This reduces code complexity.
kroening
force-pushed
the
use_make_X2
branch
from
432ade2 to
aa85fb2
Compare
allredj
reviewed
Feb 10, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: aa85fb2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100360946
tautschnig
approved these changes
Feb 11, 2019
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.