Skip to content

Commit aa85fb2

Browse files
author
Daniel Kroening
committed
use the new goto_programt::make_X factories in remove_returns
This reduces code complexity.
1 parent 3df3ef6 commit aa85fb2

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/goto-programs/remove_returns.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,20 +206,19 @@ void remove_returnst::do_function_calls(
206206
rhs = side_effect_expr_nondett(
207207
function_call.lhs().type(), i_it->source_location);
208208

209-
goto_programt::targett t_a=goto_program.insert_after(i_it);
210-
t_a->make_assignment();
211-
t_a->source_location=i_it->source_location;
212-
t_a->code=code_assignt(function_call.lhs(), rhs);
209+
goto_programt::targett t_a = goto_program.insert_after(
210+
i_it,
211+
goto_programt::make_assignment(
212+
code_assignt(function_call.lhs(), rhs), i_it->source_location));
213213

214214
// fry the previous assignment
215215
function_call.lhs().make_nil();
216216

217217
if(!is_stub)
218218
{
219-
goto_programt::targett t_d=goto_program.insert_after(t_a);
220-
t_d->make_dead();
221-
t_d->source_location=i_it->source_location;
222-
t_d->code = code_deadt(*return_value);
219+
goto_program.insert_after(
220+
t_a,
221+
goto_programt::make_dead(*return_value, i_it->source_location));
223222
}
224223
}
225224
}

0 commit comments

Comments
 (0)