Skip to content

bugfix: must do .update() after remove_returns #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Feb 9, 2019

remove_returns inserts new instructions, and thus, .update() must be called.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

remove_returns inserts new instructions, and thus, .update() must be called.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: d09eb77).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100346835

@kroening
Copy link
Member Author

To see a reason why this is needed, look at #4001. This fails without the fix.

@kroening kroening merged commit abbb389 into develop Feb 10, 2019
@kroening kroening deleted the missing_update_fix branch February 10, 2019 12:01
@tautschnig
Copy link
Collaborator

If remove_returns requires a call to .update(), why is remove_returns not made to call .update()?

@tautschnig tautschnig mentioned this pull request Feb 11, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants