-
Notifications
You must be signed in to change notification settings - Fork 274
Remove language_uit as it is no longer used #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
1d054a8
to
f23f519
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: f23f519).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99082540
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
@allredj @peterschrammel @thk123 I suspect this needs a genuine TG bump. I'm not sure whether the solution is as simple as removing an unnecessary include or actually needs the kind of (improvement work) that was done in #3683. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thk123, seems the header is still included in TG, but not used.
I am looking into the TG fix. |
@tautschnig Please re-base on latest CBMC develop branch. The joel-bot should then pass. |
This isn't used, we use cbmc_parse_optionst here.
Use initialize_goto_model to obtain goto programs, don't run parse() etc. directly.
f23f519
to
ef193de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: ef193de).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99673225
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
The joel-bot failure looks unrelated to the changes in this PR. The error is |
Thanks @thomasspriggs - I guess the update after #3126 isn't merged yet (or was not at the time of the bot running). |
I have now merged the corresponding TG PR for #3126. So the joel bot should start passing again, on future runs. |
Use initialize_goto_model to obtain goto programs, don't run parse() etc.
directly.
Only the last commit is new, the first four are #3683.