remove goto_programt::instructiont::function member [blocks: #3113] #3126

kroening · 2018-10-09T07:55:52Z

Each commit message has a non-empty body, explaining why the change was made.
My contribution is formatted in line with CODING_STANDARD.md.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.

tautschnig

If we can actually do this then that's great, but it will require some more work.

tautschnig · 2018-10-09T08:05:46Z

src/goto-programs/goto_program.h

-  ///
-  /// \param p: the goto program
-  /// \return id of the function that contains the goto program
-  static const irep_idt get_function_id(


This function is actually used and thus any of its call-sites need to be modified.

martin-cs · 2018-10-09T08:06:15Z

@chrisr-diffblue : something gives me a feeling this may break a branch you maintain for a customer. You might want to check.

kroening · 2018-10-09T09:56:51Z

@tautschnig There will be a few places where the name of the function currently looked at will have to be passed down the call-tree; but I don't expect that many.

tautschnig · 2019-01-31T14:37:39Z

It seems this finally passes on CBMC and has all the approvals, but as expected it fails with TG. @allredj @peterschrammel @thk123 Could you please figure out whether that work can be scheduled? I have no idea how much effort that is...

thk123 · 2019-02-01T12:01:01Z

Creating a bump for this now.

thk123 · 2019-02-01T12:01:37Z

@kroening Could I get this rebased to create the bump.

tautschnig · 2019-02-01T12:24:03Z

@thk123 rebased.

thk123 · 2019-02-01T13:45:11Z

@tautschnig And now failing CI here 😞

tautschnig · 2019-02-01T16:29:04Z

Err, sure ... @thk123 should be fixed now.

thk123 · 2019-02-01T16:53:02Z

TG bump created - will let you know when it passes.

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 5c5f9fe).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99459448
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

thk123 · 2019-02-04T14:30:02Z

TG bump is passing on this 👍

This member is being removed, there is nothing to validate about it.

tautschnig · 2019-02-04T14:33:54Z

Thanks @thk123, I will rebase and then merge.

We no longer need to change an instruction's function member, but should update the source location instead.

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 8ddd9ba).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99659348
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

kroening added the work in progress label Oct 9, 2018

kroening requested review from peterschrammel, pkesseli, smowton and tautschnig as code owners October 9, 2018 07:55

kroening force-pushed the goto-instruction-function branch from 0c079da to d0d8271 Compare October 9, 2018 07:57

kroening mentioned this pull request Oct 9, 2018

remove two fields from goto-binary function format #3113

Merged

7 tasks

tautschnig previously requested changes Oct 9, 2018

View reviewed changes

kroening force-pushed the goto-instruction-function branch from 9c87e96 to d1eae28 Compare October 9, 2018 10:21

kroening requested review from chrisr-diffblue and martin-cs as code owners October 9, 2018 10:21

kroening force-pushed the goto-instruction-function branch from d1eae28 to 8812e2d Compare October 9, 2018 21:10

kroening requested review from cesaro, cristina-david, NathanJPhillips and thk123 as code owners October 9, 2018 21:10

kroening force-pushed the goto-instruction-function branch 3 times, most recently from d0c7f41 to dfae80c Compare October 10, 2018 11:00

owen-mc-diffblue mentioned this pull request Oct 10, 2018

AI transformers now get function identifiers #3132

Merged

7 tasks

kroening force-pushed the goto-instruction-function branch 2 times, most recently from cc078b5 to 7036a99 Compare October 14, 2018 22:41

tautschnig assigned kroening Oct 18, 2018

kroening force-pushed the goto-instruction-function branch from 7036a99 to 16c6c32 Compare November 5, 2018 14:19

tautschnig changed the title ~~remove goto_programt::instructiont::function member~~ remove goto_programt::instructiont::function member [blocks: #3113] Nov 7, 2018

tautschnig added the blocker label Nov 7, 2018

kroening force-pushed the goto-instruction-function branch 2 times, most recently from cb12035 to 45611eb Compare November 7, 2018 12:44

tautschnig assigned thk123 and allredj and unassigned chrisr-diffblue Jan 31, 2019

tautschnig added the do not merge label Jan 31, 2019

tautschnig force-pushed the goto-instruction-function branch from 0e9e01e to 787409d Compare February 1, 2019 12:23

tautschnig force-pushed the goto-instruction-function branch from 787409d to 5c5f9fe Compare February 1, 2019 16:28

allredj reviewed Feb 1, 2019

View reviewed changes

Remove validation of instructiont::function as it is going away

22373c1

This member is being removed, there is nothing to validate about it.

Daniel Kroening and others added 2 commits February 4, 2019 14:35

remove goto_programt::instructiont::function member

c9c872e

goto_inline: replace source location if adjust_function is set

8ddd9ba

We no longer need to change an instruction's function member, but should update the source location instead.

tautschnig force-pushed the goto-instruction-function branch from 5c5f9fe to 8ddd9ba Compare February 4, 2019 14:43

tautschnig assigned tautschnig and unassigned thk123, peterschrammel and allredj Feb 4, 2019

tautschnig removed the do not merge label Feb 4, 2019

tautschnig merged commit 4adcfd8 into develop Feb 4, 2019

tautschnig deleted the goto-instruction-function branch February 4, 2019 17:16

allredj reviewed Feb 4, 2019

View reviewed changes

tautschnig mentioned this pull request Feb 4, 2019

Remove language_uit as it is no longer used #3824

Merged

3 tasks

FrNecas mentioned this pull request Aug 19, 2021

Update to CBMC 5.12 diffblue/2ls#152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove goto_programt::instructiont::function member [blocks: #3113] #3126

remove goto_programt::instructiont::function member [blocks: #3113] #3126

Uh oh!

kroening commented Oct 9, 2018

Uh oh!

tautschnig left a comment

Uh oh!

tautschnig Oct 9, 2018

Uh oh!

martin-cs commented Oct 9, 2018

Uh oh!

kroening commented Oct 9, 2018

Uh oh!

tautschnig commented Jan 31, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

tautschnig commented Feb 1, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

tautschnig commented Feb 1, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

allredj left a comment

Uh oh!

thk123 commented Feb 4, 2019

Uh oh!

tautschnig commented Feb 4, 2019

Uh oh!

allredj left a comment

Uh oh!

Uh oh!

remove goto_programt::instructiont::function member [blocks: #3113] #3126

remove goto_programt::instructiont::function member [blocks: #3113] #3126

Uh oh!

Conversation

kroening commented Oct 9, 2018

Uh oh!

tautschnig left a comment

Choose a reason for hiding this comment

Uh oh!

tautschnig Oct 9, 2018

Choose a reason for hiding this comment

Uh oh!

martin-cs commented Oct 9, 2018

Uh oh!

kroening commented Oct 9, 2018

Uh oh!

tautschnig commented Jan 31, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

tautschnig commented Feb 1, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

tautschnig commented Feb 1, 2019

Uh oh!

thk123 commented Feb 1, 2019

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

thk123 commented Feb 4, 2019

Uh oh!

tautschnig commented Feb 4, 2019

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!