AI transformers now get function identifiers #3132
Conversation
kroening
commented
Oct 9, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- My contribution is formatted in line with CODING_STANDARD.md.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel and
thk123
as code owners
src/analyses/constant_propagator.h
Outdated
| { | ||
| operator()(goto_function, ns); | ||
| replace(goto_function, ns); | ||
| } |
There was a problem hiding this comment.
Why is this removed? This seems unrelated to the change described in the commit message.
There was a problem hiding this comment.
I've put it back in, with a function identifier.
|
@martin-cs I assume it is because of #3126 |
|
@owen-jones-diffblue : thank you; that does make more sense. |
kroening
force-pushed
the
ai-function-ids
branch
2 times, most recently
from
261dfc9 to
04c5277
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 261dfc9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87594310
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 04c5277).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87596523
There was a problem hiding this comment.
Looks good except as noted by @owen-jones-diffblue: using isn't currently the recommended approach. Also, it would be nice if the commit message could please say that this is part of the larger effort that #3126 is.
|
Using vs typedef: see PR #3270 |
kroening
force-pushed
the
ai-function-ids
branch
from
04c5277 to
0190c10
Compare
|
@chrisr-diffblue Done! |
kroening
force-pushed
the
ai-function-ids
branch
from
0190c10 to
9b8f6cc
Compare
This enables removing the function identifiers from the goto program instructions.
kroening
force-pushed
the
ai-function-ids
branch
from
9b8f6cc to
09b5ac1
Compare
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 09b5ac1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90316108
