-
Notifications
You must be signed in to change notification settings - Fork 274
Remove shadowing "options" from jdiff/goto_diff methods [blocks: #2310] #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 5243777).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96307609
5243777
to
717ed29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 717ed29).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96870618
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer removing the inheritance from language_uit
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goto-analyzer changes seem fine.
717ed29
to
35682c6
Compare
@peterschrammel This should be done now, please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 35682c6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97567687
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
I am surprised this trips up TG. @peterschrammel when reviewing, could you please also check what's going on on that side. |
35682c6
to
2e00325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 2e00325).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98030661
2e00325
to
9e2cafa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9e2cafa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98123412
9e2cafa
to
85d27e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 85d27e5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98715502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 85d27e5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98715502
85d27e5
to
c83f868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: c83f868).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98930579
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
These functions are neither provided by any base classes nor is anyone inheriting from these classes.
"preprocessing" is not actually defined.
Parsing is encapsulated in initialize_goto_model.
Parsing is encapsulated in initialize_goto_model.
c83f868
to
cb43524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: cb43524).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99030561
As these inherit from language_uit, there is already an options member
available. Also do not make functions virtual unnecessarily, there is not
inheritance anywhere.