Skip to content

Move Travis jobs using clang 6.0 to clang 7 #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

tautschnig
Copy link
Collaborator

More recent versions of Clang provide additional warnings that we may benefit
from when run in CI.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

More recent versions of Clang provide additional warnings that we may benefit
from when run in CI.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f51a3d4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89532192

@thk123
Copy link
Contributor

thk123 commented Oct 29, 2018

Will make a bump moving TG to the same version of clang (and a reminder that I never got my move to clang-6 merge!)

@tautschnig
Copy link
Collaborator Author

@thk123 Clang-6: #2876?

@tautschnig
Copy link
Collaborator Author

@peterschrammel @thk123 @forejtv Could you please take a look at this one? #3301 should really not be happening.

Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet got my TG clang-6 to work yet, but that isn't really a reason not to move to 7 here anyway.

@tautschnig tautschnig merged commit 5187d57 into diffblue:develop Nov 9, 2018
@tautschnig tautschnig deleted the clang-7 branch November 9, 2018 12:34
thk123 pushed a commit that referenced this pull request Feb 15, 2019
Was saying 3.8, but CBMC moved to version 7 in #3245
thk123 pushed a commit that referenced this pull request Feb 15, 2019
Was saying 3.8, but CBMC moved to version 7 in #3245

Fixup previous commit

fixup previous commit

add explanation about --binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants