Update version of clang format in CODING_STANDARDs #4196
Conversation
thk123
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
CODING_STANDARD.md
Outdated
| ``` | ||
| *Important:* If your branch is based on a branch other than `upstream/develop`, | ||
| use the name or checksum of that branch instead. It is strongly recommended to | ||
| rebase your work onto the tip of the branch it's based on before running | ||
| `git-clang-format` in this way. | ||
|
|
||
| Note: git-clang-format uses the git config variable `clangformat.binary` so if you | ||
| have multiple versions of clang-format installed, you might need to update this. |
There was a problem hiding this comment.
"or explicitly specify the binary to use via --binary clang-format-7."
There was a problem hiding this comment.
I didn't know about the clangformat.binary variable... ;-)
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: c03e326).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101102370
|
@thk123 Would you mind squashing the commits? |
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 742d7f7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101103587
Was saying 3.8, but CBMC moved to version 7 in #3245 Fixup previous commit fixup previous commit add explanation about --binary
thk123
force-pushed
the
update-clang-format-docs
branch
from
ef6de2a to
4a005d9
Compare
|
@tautschnig done. |
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: ef6de2a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101107899
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4a005d9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101152389
Was saying 3.8, but CBMC moved to version 7 in #3245
Spotted whilst looking for something else.