Travis: Use clang-6.0 and mark all builds as sudo: false #2876
Conversation
tautschnig
requested review from
forejtv,
peterschrammel and
thk123
as code owners
tautschnig
force-pushed
the
no-travis-sudo
branch
from
65cdd61 to
2269508
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 2269508).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
tautschnig
force-pushed
the
no-travis-sudo
branch
from
2269508 to
c8414c5
Compare
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: c8414c5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85963903
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: c8414c5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85969498
|
Does anyone actually have concerns about moving to clang-6.0 (and thus removing clang-3.7 checks from CI, which means that we might lose clang-3.7 compatibility without noticing)? I have removed the do-not-merge label and will leave it to @forejtv @peterschrammel @thk123 to approve or disapprove. |
|
@peterschrammel Unless you object, I think we should move TG across to clang-6.0 at the same time to avoid running into problems if cbmc breaks on older versions of clang. I will create a PR doing that Does this have any implications for the fact we use clang-format-3.8, should we consider moving that to |
|
@tautschnig Any chance I could get a rebase on this as it rolls back quite a lot of commits |
This effectively reverts 93bc946 and instead switches the clang-3.7 builds to clang-6.0
tautschnig
force-pushed
the
no-travis-sudo
branch
from
c8414c5 to
5f556da
Compare
|
@thk123 Rebase done! |
I have created #3148, let's see what CI says for that one :-) |
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 5f556da).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87758332
|
@tautschnig : not objections per-say but concerns. When clang format was first introduced I remember there being a discussion about whether the formatted code produced by it would be stable across versions. The proposed solution was "we'll just stick with 3.8 for ever". I don't know whether that was in response to specific issues with updating so I think it might be worth seeing if it's going to need / mandate major code changes. |
|
@martin-cs Note that this particular PR is actually about updating |
|
@tautschnig : that's good and sorry for getting the wrong end of the stick. |
Do not merge: this reverts several changes to the Travis configuration merged over the last days and moves to Clang 6.0.
Creating this PR as an experiment to see whether Travis have got their infrastructure back in shape.Desired benefit: container-based builds should be faster, and thus this should be the preferable long-term option.