Skip to content

Proposal: introduce a goto-checker module [blocks: #2212, #3268] #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Proposal: introduce a goto-checker module [blocks: #2212, #3268] #2883

wants to merge 1 commit into from

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Sep 2, 2018 •
edited
Loading

This module will contain the interfaces for all our engines that can check assertions
so that they can be used interchangeably in driver programs.

Next steps:

  1. Refactor property_checker and safety_checker to provide the interfaces that I need.
  2. Split bmct into the 9 different functionalities that it currently provides.
  3. Refactor TG's bmc_cover to be able to use different engines
  4. Refactor the incremental BMC patch

Relates to #15.

This was referenced Sep 2, 2018
Merged
Merged
tautschnig
tautschnig requested changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a great idea, but it's finally time to add comments to those interfaces. We've now got a directory with files void of comments. This is unusable by anyone other than those who conceived it.

@tautschnig tautschnig changed the title Proposal: introduce a goto-checker module Proposal: introduce a goto-checker module [blocks: #2212, #3268] Nov 10, 2018
@peterschrammel peterschrammel mentioned this pull request Dec 10, 2018
Merged
5 tasks
@smowton
Copy link
Contributor

smowton commented Dec 12, 2018

Assigning @tautschnig as I think this wants re-review from him

@peterschrammel
Copy link
Member Author

The actual PR stack is coming in stacking onto #3557.

I'll close this PR (2883) when then entire stack has been PRed.

@tautschnig
Copy link
Collaborator

@peterschrammel Has the time come to close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig requested changes

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@mgudemann mgudemann Awaiting requested review from mgudemann

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

Assignees

@tautschnig tautschnig

@peterschrammel peterschrammel

Labels
blocker do not merge do not review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterschrammel @smowton @tautschnig