Factor out program_only from bmct #2885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
mgudemann,
pkesseli,
smowton and
tautschnig
as code owners
peterschrammel
force-pushed
the
factor-out-program-only
branch
3 times, most recently
from
b33606f to
03b49ae
Compare
tautschnig
requested changes
Sep 3, 2018
peterschrammel
force-pushed
the
factor-out-program-only
branch
from
03b49ae to
e425337
Compare
|
@tautschnig, moved. |
tautschnig
approved these changes
Sep 3, 2018
src/goto-symex/show_program.h
Outdated
| /// Output of the program (SSA) constraints | ||
|
|
||
| #ifndef CPROVER_GOTO_CHECKER_SHOW_PROGRAM_H | ||
| #define CPROVER_GOTO_CHECKER_SHOW_PROGRAM_H |
There was a problem hiding this comment.
The header guard needs fixing-up.
tautschnig
reviewed
Sep 3, 2018
src/goto-symex/show_program.cpp
Outdated
|
|
||
| std::cout << "\n" << "Program constraints:" << "\n"; | ||
| std::cout << "\n" |
There was a problem hiding this comment.
If you're doing some cleanup work here, I'd suggest to replace all occurrences of "\n" by '\n' (single character instead of string).
tautschnig
reviewed
Sep 3, 2018
src/goto-symex/show_program.cpp
Outdated
| void show_program(const namespacet &ns, const symex_target_equationt &equation) | ||
| { | ||
| unsigned count=1; | ||
| unsigned count = 1; |
There was a problem hiding this comment.
This should be std::size_t.
peterschrammel
force-pushed
the
factor-out-program-only
branch
from
e425337 to
a889a16
Compare
|
Yes, there's quite some cleanup and refactoring in the following PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2883
Only review last two commits
Could also be moved to goto-symex