Factor out show_vcc from bmct #2884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
mgudemann,
pkesseli,
smowton and
tautschnig
as code owners
peterschrammel
changed the title
peterschrammel
force-pushed
the
move-show-vcc
branch
4 times, most recently
from
4804ee0 to
16264b0
Compare
tautschnig
requested changes
Sep 3, 2018
peterschrammel
force-pushed
the
move-show-vcc
branch
from
16264b0 to
a1c327a
Compare
|
@tautschnig, moved. |
tautschnig
approved these changes
Sep 3, 2018
tautschnig
assigned cesaro, smowton, mgudemann and pkesseli and unassigned peterschrammel
peterschrammel
force-pushed
the
move-show-vcc
branch
from
a1c327a to
5f26ece
Compare
peterschrammel
assigned peterschrammel and unassigned cesaro, smowton, mgudemann and pkesseli
mgudemann
reviewed
Sep 3, 2018
| @@ -69,7 +69,6 @@ BMC_DEPS =../src/cbmc/all_properties$(OBJEXT) \ | |||
| ../src/cbmc/cbmc_solvers$(OBJEXT) \ | |||
| ../src/cbmc/counterexample_beautification$(OBJEXT) \ | |||
| ../src/cbmc/fault_localization$(OBJEXT) \ | |||
| ../src/cbmc/show_vcc$(OBJEXT) \ | |||
There was a problem hiding this comment.
is the moved one not needed here ?
There was a problem hiding this comment.
The moved one is dragged in implicitly via goto-symex$(LIBEXT).
peterschrammel
force-pushed
the
move-show-vcc
branch
from
5f26ece to
795e988
Compare
mgudemann
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2883Only review last commitCould also be moved to goto-symex [done]