Skip to content

Support Python 3.13 and update deps #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

dhirschfeld
Copy link
Contributor

@dhirschfeld dhirschfeld commented Feb 19, 2025

All tests pass1 with no explicit numpy dependency.


Resolves #509
Closes #504 - (changes have been merged here)

Footnotes

  1. Except the broken DCO check

dbaxa and others added 6 commits February 13, 2025 10:03
* Remove upper caps on numpy and pyarrow versions

Signed-off-by: David Black <[email protected]>
Signed-off-by: David Black <[email protected]>
Signed-off-by: Dave Hirschfeld <[email protected]>
Signed-off-by: Dave Hirschfeld <[email protected]>
@dhirschfeld
Copy link
Contributor Author

It looks like your DCO workflow might be broken?

image

@dhirschfeld dhirschfeld changed the title Move numpy to dev dependencies Support Python 3.13 and update deps Feb 20, 2025
@dbaxa
Copy link
Contributor

dbaxa commented Feb 20, 2025

@samikshya-db
Copy link
Contributor

Thanks for raising this, @dhirschfeld. For passing the DCO test, we need to have signed off by ... in the github commit message - as mentioned in https://github.com/databricks/databricks-sql-python/blob/main/CONTRIBUTING.md#sign-your-work

DCO tests in GitHub Actions ensure code contributions are legally sound. We are implementing stricter DCO checks. Currently, DCO compliance is not enforced as a pre-merge requirement.

Sample PR where DCO passes : https://github.com/databricks/databricks-sql-python/pull/461/commits.

@samikshya-db samikshya-db self-requested a review February 24, 2025 08:06
@dbaxa
Copy link
Contributor

dbaxa commented Feb 25, 2025

Thanks for raising this, @dhirschfeld. For passing the DCO test, we need to have signed off by ... in the github commit message - as mentioned in https://github.com/databricks/databricks-sql-python/blob/main/CONTRIBUTING.md#sign-your-work

DCO tests in GitHub Actions ensure code contributions are legally sound. We are implementing stricter DCO checks. Currently, DCO compliance is not enforced as a pre-merge requirement.

Sample PR where DCO passes : https://github.com/databricks/databricks-sql-python/pull/461/commits.

@samikshya-db - I had sign offs in my commit messages and my PR (#504) still was red for DCO. The check seems to be failing because of permissions issues no?

Run tisonkun/[email protected]
Error: Although you appear to have the correct authorization credentials, the `databricks` organization has an IP allow list enabled, and your IP address is not permitted to access this resource.

& the comment fails due to a different perms issue it seems.

     },
    data: {
      message: 'Resource not accessible by integration',
      documentation_url: 'https://docs.github.com/rest/issues/comments#create-an-issue-comment',
      status: '403'
    }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/databricks/databricks-sql-python/issues/504/comments',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'actions/github-script octokit-core.js/3.6.0 Node.js/20.18.0 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"body":"Thanks for your contribution! To satisfy the DCO policy in our   [contributing guide](https://github.com/databricks/databricks-sql-python/blob/main/CONTRIBUTING.md)   every commit message must include a sign-off message. One or more of your commits is missing this message.   You can reword previous commit messages with an interactive rebase (`git rebase -i main`)."}',
    request: { agent: [Agent], hook: [Function: bound bound register] }
  }
}

@dhirschfeld
Copy link
Contributor Author

As @dbaxa says, all commits have been signed off. The DCO check is broken because the necessary IP address is being blocked.

image

@samikshya-db
Copy link
Contributor

samikshya-db commented Feb 27, 2025

DCO sign-off should be part of every commit for the DCO GH action to pass (the merge commit too). The message that you posted is actually a red-herring. I agree that this GH action should be more developer friendly :/ Created : #519 to address this.

Thanks for the contribution!

@samikshya-db samikshya-db merged commit e11fa91 into databricks:main Feb 27, 2025
20 of 21 checks passed
@dhirschfeld dhirschfeld deleted the remove-numpy branch February 27, 2025 08:43
@dhirschfeld
Copy link
Contributor Author

Thanks for the merge @samikshya-db!

If anyone here has commit rights in databricks-sqlalchemy I have a similar PR over there to allow installing into a modern environment:

wyattscarpenter pushed a commit to wyattscarpenter/databricks-sql-python that referenced this pull request Mar 11, 2025
* Remove upper caps on dependencies (databricks#452)

* Remove upper caps on numpy and pyarrow versions

Signed-off-by: David Black <[email protected]>

* Added CI CD upto python 3.13

Signed-off-by: David Black <[email protected]>

* Specify pandas 2.2.3 as the lower bound for python 3.13

Signed-off-by: David Black <[email protected]>

* Specify pyarrow 18.0.0 as the lower bound for python 3.13

Signed-off-by: David Black <[email protected]>

* Move `numpy` to dev dependencies

Signed-off-by: Dave Hirschfeld <[email protected]>

* Updated lockfile

Signed-off-by: Dave Hirschfeld <[email protected]>

---------

Signed-off-by: David Black <[email protected]>
Signed-off-by: Dave Hirschfeld <[email protected]>
Co-authored-by: David Black <[email protected]>
Signed-off-by: wyattscarpenter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow installing with numpy>=2
3 participants