Skip to content

Allow installing with numpy>=2 #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhirschfeld opened this issue Feb 19, 2025 · 3 comments · Fixed by #510
Closed

Allow installing with numpy>=2 #509

dhirschfeld opened this issue Feb 19, 2025 · 3 comments · Fixed by #510
Assignees
Labels
enhancement New feature or request

Comments

@dhirschfeld
Copy link
Contributor

numpy = [
{ version = "^1.16.6", python = ">=3.8,<3.11" },
{ version = "^1.23.4", python = ">=3.11" },
]

It was changed in #444, but there didn't appear to be any justification for the change:

Image

@dhirschfeld
Copy link
Contributor Author

AFAICT numpy isn't even a direct dependency - we import it only in the tests so it shouldn't be listed as a dependency of databricks-sql-connector.

https://github.com/search?q=repo%3Adatabricks%2Fdatabricks-sql-python%20numpy&type=code

@samikshya-db samikshya-db added the enhancement New feature or request label Feb 24, 2025
@samikshya-db samikshya-db self-assigned this Feb 24, 2025
@akoshel
Copy link

akoshel commented Feb 26, 2025

Hi
databricks-sql-connector makes poetry builds fail due to PEP 517
python-poetry/poetry#9351

@samikshya-db
Copy link
Contributor

@akoshel - Looks like the issue is closed. Can you open a new issue if your concerns are not addressed yet? [Maybe you can attach logs/ more context on the issue too]

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants