Skip to content

Make DCO check more developer friendly #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samikshya-db opened this issue Feb 27, 2025 · 2 comments
Open

Make DCO check more developer friendly #519

samikshya-db opened this issue Feb 27, 2025 · 2 comments
Assignees
@madhav-db

Comments

@samikshya-db
Copy link
Contributor

DCO tests in GitHub Actions ensure code contributions are legally sound. We are implementing stricter DCO checks. Currently, DCO compliance is not enforced as a pre-merge requirement.

Sample PR where DCO passes : https://github.com/databricks/databricks-sql-python/pull/461/commits.

But, sadly the sign-off should be part of every commit message for DCO GH action to pass. The idea is to make it more developer friendly.
@samikshya-db samikshya-db mentioned this issue Feb 27, 2025
Merged
@madhav-db madhav-db self-assigned this Feb 27, 2025
@dhirschfeld
Copy link
Contributor

I suppose it's theoretically possible to rewrite history to add a Signed-off-by to a merge commit, but I don't think that really makes much sense and it would be better for the check to ignore merge commits.

@dhirschfeld
Copy link
Contributor

The DCO check does appear to be broken though:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhav-db madhav-db

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhirschfeld @madhav-db @samikshya-db