Skip to content

Add urllib3 as an explicit dependency #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacobus-herman opened this issue Aug 10, 2023 · 4 comments · Fixed by #191
Closed

Add urllib3 as an explicit dependency #190

jacobus-herman opened this issue Aug 10, 2023 · 4 comments · Fixed by #191

Comments

@jacobus-herman
Copy link
Contributor

Hi!

Can you please add urllib3 as an explicit dependency to your package? I see that in the latest version, i.e. 2.9.0, you are using BaseHTTPResponse from urllib3 and this is only available in urllib3>=2.0.0. So can you either add this dependency or change the code to accommodate older versions of urllib3? :)

@susodapop
Copy link
Contributor

Thanks for opening this issue! Excellent catch.

potiuk added a commit to potiuk/airflow that referenced this issue Aug 11, 2023
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.
potiuk added a commit to apache/airflow that referenced this issue Aug 11, 2023
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this issue Aug 17, 2023
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.
@dthemg
Copy link

dthemg commented Aug 18, 2023

An issue with this is that botocore requires urllib3 version 1, you can't have both installed:

botocore 1.31.29 requires urllib3<1.27,>=1.25.4, but you have urllib3 2.0.4 which is incompatible

@susodapop
Copy link
Contributor

susodapop commented Aug 18, 2023 via email

@susodapop
Copy link
Contributor

Release 2.9.2 is now live on Pypi

phanikumv pushed a commit to astronomer/astro-sdk that referenced this issue Mar 26, 2024
We included the `databricks-sql-connector` dependency due to the reasons
stated in the GitHub issue
databricks/databricks-sql-python#190. Now that
this issue has been fixed, we should remove this dependency.
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 18, 2024
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.

GitOrigin-RevId: 5f8f25b34c9e8c0d4845b014fc8f1b00cc2e766f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 19, 2024
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.

GitOrigin-RevId: 5f8f25b34c9e8c0d4845b014fc8f1b00cc2e766f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 8, 2024
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.

GitOrigin-RevId: 5f8f25b34c9e8c0d4845b014fc8f1b00cc2e766f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue May 4, 2025
The connector 2.9.0 released on Aug 10, 2023 has a bug that it does not
properly declare urllib3 and it needs to be excluded. See
databricks/databricks-sql-python#190
The 2.9.1 (to be released soon) already contains the fix.

GitOrigin-RevId: 5f8f25b34c9e8c0d4845b014fc8f1b00cc2e766f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants