-
Notifications
You must be signed in to change notification settings - Fork 104
Update pyproject.toml to fix issues seen in dbt-databricks #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This closes #326 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than re-pin the dependency, we could instead write a version-contingent fix for this that checks the urllib3
version at runtime rather than locking out older users.
This can't merge until we add the new poetry.lock
file as well. Instructions for this are within CONTRIBUTING.md (but I'll take care of it for you.
@@ -26,7 +26,7 @@ numpy = [ | |||
sqlalchemy = { version = ">=2.0.21", optional = true } | |||
openpyxl = "^3.0.10" | |||
alembic = { version = "^1.0.11", optional = true } | |||
urllib3 = ">=1.0" | |||
urllib3 = ">=1.26" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern with this pin version is anyone using an older urllib3 than 1.26, as these were the users who voiced issues when we originally released with the version pinned to urllib3>=2.0.0
.
Looking through past issues, it seems that as long as we still support urllib3==1.27.0
then the previous issues would still be avoided:
I also checked the default version of urllib3
in a DBSQL notebook and it's 1.26.14, so I think this change is acceptable.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Ben Cassell <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
97d463d
to
b74e9bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@@ -2,13 +2,13 @@ | |||
|
|||
[[package]] | |||
name = "alembic" | |||
version = "1.12.1" | |||
version = "1.13.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped alongside sqlalchemy
Signed-off-by: Jesse Whitehouse <[email protected]>
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Jesse Whitehouse <[email protected]>
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Synced with |
pandas 2.2.0 causes several issues, notably:
and urllib < 1.26 gives an error about Retry not having allowed_methods in its
__init__