Skip to content

Add urllib3 dependency #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Add urllib3 dependency #191

merged 2 commits into from
Aug 10, 2023

Conversation

jacobus-herman
Copy link
Contributor

fixes #190

Signed-off-by: Jacobus Herman <[email protected]>
Copy link
Contributor

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm running our e2e tests with this change and then will merge to main.

Cheers

@susodapop
Copy link
Contributor

All tests pass. I updated the CHANGELOG on the branch.

@susodapop susodapop merged commit 0d99fc7 into databricks:main Aug 10, 2023
susodapop pushed a commit to unj1m/databricks-sql-python that referenced this pull request Sep 19, 2023
Signed-off-by: Jacobus Herman <[email protected]>

Co-authored-by: Jesse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add urllib3 as an explicit dependency
2 participants