Rename get_namespace to array_namespace #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_namespace is maintained as a backwards compatible alias. Fixes data-apis#19.
|
(this is built on #25. The diff should clear once that is merged) |
asmeurer
force-pushed
the
array_namespace
branch
from
fc6aa30 to
eaf1e52
Compare
|
Thoughts on this? I want to release the fixes from #25 but if we are going to do this we should do it now. |
|
It seems fine to me. Honestly I'm not sure it's that much better a name, but |
|
Sounds good to me, too. I don't recall putting much thought into this name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_namespace is kept as a backwards compatible wrapper to array_namespace
Making this as a separate PR from #25 as it might be more controversial.
Fixes #19.