Skip to content

Various fixes for the torch wrapper #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Mar 10, 2023
Merged

Various fixes for the torch wrapper #25

merged 33 commits into from
Mar 10, 2023

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Mar 6, 2023

Primarily from @thomasjpfan's feedback.

asmeurer added 16 commits March 6, 2023 15:50
@asmeurer
Add torch wrappers for ones(), zeros(), and empty()
19dc410 
This allows shape to be passed as a keyword argument.

Fixes data-apis#22.
@asmeurer
Allow the xfails and skips files to be specified as inputs
642bbd1
@asmeurer
Use package-version as an input instead
6b6b487 
GitHub Actions expressions are very limited in what you can do with them. The
default cannot reference another variable, and there is no way to do
manipulation or "if" clauses with them.
@asmeurer
Add GitHub Actions tests for NumPy 1.21
80a20e8
@asmeurer
Fix workflow names
c24abe4
@asmeurer
Try fixing the pytest invocation
e414cf4
@asmeurer
Use a different approach to get a different xfails file for numpy 1.21
592eded
@asmeurer
Fix typo
2490692
@asmeurer
Don't run NumPy 1.21 in Python 3.11
ab3a1c9
@asmeurer
Use better syntax to skip 3.11
68dd2ea
@asmeurer
Set the Python version in an environment variable
912fd11
@asmeurer
Move the Numpy 1.21 skip to the main config file
8358e1c
@asmeurer
Try to fix workflow syntax
eaf7b0a
@asmeurer
Try to fix workflow syntax
20c56be
@asmeurer
Move the if down to the steps
78dc3e5
@asmeurer
Fix torch std() with integral float correction
e7e1fb5 
Fixes data-apis#24
@asmeurer asmeurer mentioned this pull request Mar 7, 2023
Closed
@asmeurer asmeurer mentioned this pull request Mar 7, 2023
Closed
@asmeurer asmeurer mentioned this pull request Mar 8, 2023
Closed
@asmeurer
Copy link
Member Author

asmeurer commented Mar 8, 2023

This is ready for review.

@asmeurer asmeurer requested a review from rgommers March 8, 2023 02:27
rgommers
rgommers approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. One CI job for numpy 1.21 still has 8 failures, which all don't look too interesting (~1e-46 inputs to some ufuncs).

@asmeurer
Copy link
Member Author

asmeurer commented Mar 8, 2023

No worried on CI. It typically takes a few iterations to get all the possible XFAILs from hypothesis.

@asmeurer
Copy link
Member Author

asmeurer commented Mar 8, 2023

(and just to be clear, those failures are all because of value-based type promotion, which we cannot disable in NumPy 1.21)

@asmeurer asmeurer mentioned this pull request Mar 8, 2023
Merged
@asmeurer
Copy link
Member Author

asmeurer commented Mar 8, 2023

Now NumPy is crashing on CI with a floating-point exception https://github.com/asmeurer/array-api-compat/actions/runs/4368929147/jobs/7642133923. There must be some issue with mod in the C math library used on GitHub Actions.

@asmeurer asmeurer enabled auto-merge March 9, 2023 23:28
@asmeurer asmeurer merged commit 0706387 into data-apis:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmeurer @rgommers