-
Notifications
You must be signed in to change notification settings - Fork 34
rename or alias get_namespace
to array_namespace
#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the suggestion @ntessore. On the one hand, I can see that the name may be slightly nicer. On the other hand, this package is already past version 1.0, and the |
That's expected, of course, but I thought I should bring this up at least while the NEP is still a draft. |
I agree it does seem like a better name to match |
get_namespace is maintained as a backwards compatible alias. Fixes data-apis#19.
I'm actually in favor of this, but I've made it as a separate PR in case there are any objections #29. I kept |
Having a function
array_namespace
seems more intuitive thanget_namespace
, mainly due to symmetry with e.g.repr()
,str()
,iter()
,next()
, sincearray_namespace(x)
returnsx.__array_namespace__()
if it exists, and does something sensible if it does not.The text was updated successfully, but these errors were encountered: