This repository was archived by the owner on Feb 22, 2018. It is now read-only.
chore(travis): fail build if a test has been 'iit'ed #1172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,4 +29,4 @@ dev_dependencies: | |||
| benchmark_harness: '>=1.0.0' | |||
| unittest: '>=0.10.1 <0.12.0' | |||
| mock: '>=0.10.0 <0.12.0' | |||
| guinness: '>=0.1.3 <0.2.0' | |||
| guinness: '>=0.1.9 <0.2.0' | |||
There was a problem hiding this comment.
Please update package dependencies in a different PR
There was a problem hiding this comment.
I think this is required for this PR, see https://github.com/vsavkin/guinness/blob/master/CHANGELOG.md#v019-2014-06-18
There was a problem hiding this comment.
Yup. It is required.
There was a problem hiding this comment.
If it is required, that we need to land the guinness upgrade first and then land this PR. We still need two PRs.
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed. Closes dart-archive#922
chirayuk
added a commit
to chirayuk/angular.dart
that referenced
this pull request
Jul 31, 2014
chirayuk
added a commit
that referenced
this pull request
Aug 1, 2014
chirayuk
added a commit
that referenced
this pull request
Aug 1, 2014
chirayuk
added a commit
that referenced
this pull request
Aug 1, 2014
chirayuk
added a commit
that referenced
this pull request
Aug 5, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Aug 7, 2014
Closes dart-archive#922 Closes dart-archive#1172 Closes dart-archive#1289 Closes dart-archive#1291
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the build script to fail when a test was 'itt'ed or 'ddescribe'ed.
Closes #922