-
Notifications
You must be signed in to change notification settings - Fork 248
Conversation
This PR is ready to merge. |
We need to update guinness in the g3 branch first (it is still pinned to 0.1.3). |
This should be updated to use the latest version of Guinness before merging |
@vicb 0.1.6 is out-of-date now, could you update this for 0.1.9? |
James, I'm of this week. If @vsavkin can submit a pr to this branch then I'll merge it On 7 juillet 2014 23:29:58 CEST, James deBoer [email protected] wrote:
|
@vicb If you want I can cherry pick your commit and submit a new PR to https://github.com/angular/angular.dart. Or submit a PR to your branch. Whatever is easier for you. |
I realized that it would be easier to submit a new PR than updating this one after having commented. Pick whatever is best for you, you are the one which does the work :) On 8 juillet 2014 15:29:43 CEST, Victor Savkin [email protected] wrote:
|
Created a new PR ( #1215) updating guinness to 0.1.12 (latest) |
Closing as this will be replaced by #1215 + a yet to create |
@jbdeboer is it ok to commit an updated lock file here ? (we need guinness >= 0.1.6 for the changes)