Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

chore(guinness): update to 0.1.6 #1078

Closed
wants to merge 1 commit into from
Closed

Conversation

vicb
Copy link
Contributor

@vicb vicb commented May 28, 2014

@jbdeboer is it ok to commit an updated lock file here ? (we need guinness >= 0.1.6 for the changes)

@vicb vicb added cla: yes and removed cla: no labels May 28, 2014
@vicb vicb self-assigned this May 28, 2014
@vicb vicb changed the title chore(guinness): update to 1.5 chore(guinness): update to 0.1.6 May 28, 2014
@vicb vicb removed the DON'T MERGE label Jun 4, 2014
@vicb
Copy link
Contributor Author

vicb commented Jun 4, 2014

This PR is ready to merge.
Some feedback ?

@jbdeboer
Copy link
Contributor

jbdeboer commented Jun 4, 2014

We need to update guinness in the g3 branch first (it is still pinned to 0.1.3).

@naomiblack naomiblack added this to the 0.13.0 milestone Jun 13, 2014
@vicb vicb modified the milestones: 0.14.0, 0.13.0 Jun 25, 2014
@vicb
Copy link
Contributor Author

vicb commented Jun 25, 2014

This should be updated to use the latest version of Guinness before merging

@jbdeboer
Copy link
Contributor

jbdeboer commented Jul 7, 2014

@vicb 0.1.6 is out-of-date now, could you update this for 0.1.9?

@vicb
Copy link
Contributor Author

vicb commented Jul 7, 2014

James, I'm of this week. If @vsavkin can submit a pr to this branch then I'll merge it

On 7 juillet 2014 23:29:58 CEST, James deBoer [email protected] wrote:

@vicb 0.1.6 is out-of-date now, could you update this for 0.1.9?


Reply to this email directly or view it on GitHub:
#1078 (comment)

@vsavkin
Copy link
Contributor

vsavkin commented Jul 8, 2014

@vicb If you want I can cherry pick your commit and submit a new PR to https://github.com/angular/angular.dart. Or submit a PR to your branch. Whatever is easier for you.

@vicb
Copy link
Contributor Author

vicb commented Jul 8, 2014

I realized that it would be easier to submit a new PR than updating this one after having commented. Pick whatever is best for you, you are the one which does the work :)

On 8 juillet 2014 15:29:43 CEST, Victor Savkin [email protected] wrote:

@vicb If you want I can cherry pick your commit and submit a new PR to
https://github.com/angular/angular.dart. Or submit a PR to your branch.
Whatever is easier for you.


Reply to this email directly or view it on GitHub:
#1078 (comment)

vsavkin added a commit to vsavkin/angular.dart that referenced this pull request Jul 8, 2014
@vsavkin
Copy link
Contributor

vsavkin commented Jul 8, 2014

Created a new PR ( #1215) updating guinness to 0.1.12 (latest)

@vicb
Copy link
Contributor Author

vicb commented Jul 21, 2014

Closing as this will be replaced by #1215 + a yet to create throw -> throwWith PR

@vicb vicb closed this Jul 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants