Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

presubmit should fail if an test has been 'iit'ed #922

Closed
jbdeboer opened this issue Apr 16, 2014 · 4 comments
Closed

presubmit should fail if an test has been 'iit'ed #922

jbdeboer opened this issue Apr 16, 2014 · 4 comments

Comments

@jbdeboer
Copy link
Contributor

I am not sure of the best approach.
@blois
Copy link

blois commented Apr 17, 2014

An environment variable (bool.fromEnvironment) to disable/error when
compiling dart2js?

On Wednesday, April 16, 2014, James deBoer [email protected] wrote:

I am not sure of the best approach.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/922
.

vsavkin added a commit to vsavkin/angular.dart that referenced this issue Jun 18, 2014
@vsavkin
chore(travis): fail build if a test has been 'iit'ed
d349f5c 
Change the build script to fail when a test was 'itt'ed or 'ddescribe'ed.

Closes dart-archive#922
vsavkin added a commit to vsavkin/angular.dart that referenced this issue Jun 18, 2014
@vsavkin
chore(travis): fail build if a test has been 'iit'ed
ab602a8 
Change the build script to fail when a test was 'itt'ed or 'ddescribe'ed.

Closes dart-archive#922
@vsavkin
Copy link
Contributor

vsavkin commented Jun 18, 2014

@vicb asked me to look into it. That's what I came up with:

https://github.com/vsavkin/angular.dart/tree/fail_travis_build_when_iit_or_ddescribe

Please, take a look. If it is OK, I will submit a PR.

@vicb
Copy link
Contributor

vicb commented Jun 23, 2014

@vsavkin I've commented on your commit. LGTM, please submit the PR

vsavkin added a commit to vsavkin/angular.dart that referenced this issue Jun 23, 2014
@vsavkin
chore(travis): fail build if a test has been 'iit'ed
d33b87a 
Change the build script to fail when a test was 'itt'ed or 'ddescribe'ed.

Closes dart-archive#922
@vsavkin vsavkin mentioned this issue Jun 23, 2014
Closed
vsavkin added a commit to vsavkin/angular.dart that referenced this issue Jun 24, 2014
@vsavkin
chore(travis): fail build if a test has been 'iit'ed
91238cf 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes dart-archive#922
vsavkin added a commit to vsavkin/angular.dart that referenced this issue Jun 25, 2014
@vsavkin
chore(travis): fail build if a test has been 'iit'ed
22455e6 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes dart-archive#922
vsavkin added a commit that referenced this issue Jul 23, 2014
@vsavkin @chirayuk
chore(travis): fail build if a test has been 'iit'ed
6d4c5bc 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes #922

Closes #1172
vsavkin added a commit that referenced this issue Jul 23, 2014
@vsavkin @chirayuk
chore(travis): fail build if a test has been 'iit'ed
2b0692b 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes #922

Closes #1172
vsavkin added a commit that referenced this issue Jul 23, 2014
@vsavkin @chirayuk
chore(travis): fail build if a test has been 'iit'ed
f5ae9b1 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes #922

Closes #1172
vsavkin added a commit that referenced this issue Jul 23, 2014
@vsavkin @chirayuk
chore(travis): fail build if a test has been 'iit'ed
8e531c4 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes #922

Closes #1172
vsavkin added a commit that referenced this issue Jul 24, 2014
@vsavkin @chirayuk
chore(travis): fail build if a test has been 'iit'ed
42ca817 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes #922

Closes #1172
vsavkin added a commit that referenced this issue Jul 24, 2014
@vsavkin @chirayuk
chore(travis): fail build if a test has been 'iit'ed
3c3a1e1 
Change the build script to fail if a test was 'itt'ed or 'ddescribe'ed.

Closes #922

Closes #1172
@chirayuk chirayuk mentioned this issue Jul 31, 2014
Closed
chirayuk added a commit to chirayuk/angular.dart that referenced this issue Jul 31, 2014
@chirayuk
chore(scripts): fail on pipe failures
e76d4f0 
Closes dart-archive#922 dart-archive#1172 dart-archive#1289 dart-archive#1291
@chirayuk
Copy link
Contributor

I prefer a configuration based approach to this one.  However, that's more work.  I'll switch to that when it's ready.  The current fix doesn't work – see #1289.  I have PR #1291 to fix it.

@chirayuk chirayuk reopened this Jul 31, 2014
chirayuk added a commit that referenced this issue Aug 1, 2014
@chirayuk
chore(scripts): fail on pipe failures
c8a66c8 
Closes #922 #1172 #1289 #1291
chirayuk added a commit that referenced this issue Aug 1, 2014
@chirayuk
chore(scripts): fail on pipe failures
cdde8c4 
Closes #922
Closes #1172
Closes #1289
Closes #1291
chirayuk added a commit that referenced this issue Aug 5, 2014
@chirayuk
chore(scripts): fail on pipe failures
3d3c467 
Closes #922
Closes #1172
Closes #1289
Closes #1291
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Aug 7, 2014
@chirayuk
chore(scripts): fail on pipe failures
a46a51e 
Closes dart-archive#922
Closes dart-archive#1172
Closes dart-archive#1289
Closes dart-archive#1291
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@vsavkin @chirayuk @vicb @jbdeboer @blois