This repository was archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Clean up listeners on body from EventHandler #925
Labels
Milestone
Comments
@mhevery Isn't this already done? Looking at event handler test,, it seems like a new element is created and it's used to override ``Node` in the module - https://github.com/angular/angular.dart/blob/master/test/core_dom/event_handler_spec.dart#L33 it's also destroyed after each test - https://github.com/angular/angular.dart/blob/master/test/core_dom/event_handler_spec.dart#L39 Did you have something else in mind? |
This is EventHandler specific. I wanted something which is global to all tests. |
mvuksano
added a commit
to mvuksano/angular.dart
that referenced
this issue
May 6, 2014
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test Closes dart-archive#925
mvuksano
added a commit
that referenced
this issue
Jul 14, 2014
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test Closes #925
mvuksano
added a commit
that referenced
this issue
Aug 13, 2014
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test Closes #925
mvuksano
added a commit
that referenced
this issue
Aug 14, 2014
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test Closes #925
rkirov
pushed a commit
to rkirov/angular.dart
that referenced
this issue
Oct 10, 2014
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test Closes dart-archive#925
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Application rootNode defaults to
HTML
tag and any listeners attached to it will hang around accross all tests;https://github.com/angular/angular.dart/blob/master/lib/application.dart#L147
In tests this needs to be overwritten to point to a new div each time:
Needs to be owerwritten here: https://github.com/angular/angular.dart/blob/master/lib/mock/module.dart#L53
The text was updated successfully, but these errors were encountered: