This repository was archived by the owner on Feb 22, 2018. It is now read-only.
refactor: Refactor test setup. #1537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test Closes dart-archive#925
|
Rebased an orphaned PR, but more work needed to make tests pass. |
|
@rkirov please take a look and decide whether this can be addressed in 1.1? This is an old PR from Marko that's been floating around for a bit because of possible internal conflicts. |
|
I don't have bandwidth to make tests pass, and this is not fixing an issue that affects clients, so I am closing the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test
Closes #925