refactor: Refactor test setup.

Befor each test, a div element with attribute ng-app, is created. This is a container into which test can put some content. This container is destroyed after each test

Closes #925

Author: mvuksano

lib/mock/module.dart

@@ -56,13 +56,15 @@ part 'mock_window.dart';
  */
 class AngularMockModule extends Module {
   AngularMockModule() {
+    bind(MockApplication);
+    bind(Application, toImplementation: MockApplication);
     bind(ExceptionHandler, toImplementation: RethrowExceptionHandler);
     bind(TestBed);
     bind(Probe);
     bind(Logger);
     bind(MockHttpBackend);
-    bind(Element, toValue: document.body);
-    bind(Node, toValue: document.body);
+    bind(Element, toFactory: (app) => app.element, inject: [MockApplication]);
+    bind(Node, inject: [Element]);
     bind(HttpBackend, toInstanceOf: MOCK_HTTP_BACKEND_KEY);
     bind(VmTurnZone, toFactory: () {
       return new VmTurnZone()
@@ -74,3 +76,20 @@ class AngularMockModule extends Module {
     bind(WebPlatform, toValue: mockPlatform);
   }
 }
+
+class MockApplication extends Application {
+  var _element;
+
+  Element get element {
+    if (_element == null) {
+      _element = new DivElement()..attributes['ng-app'] = '';
+    }
+    return _element;
+  }
+
+  void destroyElement() {
+    _element = null;
+  }
+
+  Injector createInjector() => throw 'MockApplications can not create injectors';
+}

lib/mock/test_injection.dart

@@ -1,9 +1,13 @@
 library angular.mock.test_injection;
 
+import 'dart:html';
+
+import 'package:angular/application.dart';
 import 'package:angular/application_factory.dart';
 import 'package:angular/mock/module.dart';
 import 'package:di/di.dart';
 import 'dart:mirrors';
+import 'module.dart';
 
 _SpecInjector _currentSpecInjector = null;
 
@@ -61,7 +65,7 @@ class _SpecInjector {
     }
   }
 
-  reset() {
+  void reset() {
     injector = null;
     injectorCreateLocation = null;
   }
@@ -161,3 +165,12 @@ void setUpInjector() {
 void tearDownInjector() {
   _currentSpecInjector = null;
 }
+
+void cleanUpAppRoot() {
+  if (_currentSpecInjector.injector != null) {
+    var app = _currentSpecInjector.injector.get(Application);
+    assert(app is MockApplication);
+    app.destroyElement();
+  }
+  document.body.setInnerHtml('');
+}

test/_specs.dart

@@ -115,6 +115,7 @@ _removeNgBinding(node) {
 
 main() {
   gns.beforeEach(setUpInjector, priority:3);
+  gns.afterEach(cleanUpAppRoot);
   gns.afterEach(tearDownInjector);
 
   gns.guinnessEnableHtmlMatchers();

test/animate/ng_animate_spec.dart

@@ -26,10 +26,6 @@ main() {
       });
     });
 
-    afterEach(() {
-      tearDownInjector();
-    });
-
     it('should control animations on elements', () {
       _.compile('<div ng-animate="never"><div></div></div>');
       _.rootScope.apply();

test/core_dom/event_handler_spec.dart

@@ -25,60 +25,50 @@ class BarComponent {
 
 main() {
   describe('EventHandler', () {
-    Element ngAppElement;
     beforeEachModule((Module module) {
-      ngAppElement = new DivElement()..attributes['ng-app'] = '';
-      module..bind(FooController);
-      module..bind(BarComponent);
-      module..bind(Node, toValue: ngAppElement);
-      document.body.append(ngAppElement);
+      module..bind(FooController)
+            ..bind(BarComponent);
     });
 
-    afterEach(() {
-      ngAppElement.remove();
-      ngAppElement = null;
-    });
-
-    compile(_, html) {
-      ngAppElement.setInnerHtml(html, treeSanitizer: new NullTreeSanitizer());
-      _.compile(ngAppElement);
-      return ngAppElement.firstChild;
-    }
 
-    it('should register and handle event', (TestBed _) {
-      var e = compile(_,
+    it('should register and handle event', (TestBed _, Application app) {
+      var e = _.compile(
         '''<div foo>
-          <div on-abc="ctrl.invoked=true;"></div>
+          <div on-abc="ctrl.invoked=true"></div>
         </div>''');
+      document.body.append(app.element..append(e));
 
       _.triggerEvent(e.querySelector('[on-abc]'), 'abc');
       expect(_.getScope(e).context['ctrl'].invoked).toEqual(true);
     });
 
-    it('shoud register and handle event with long name', (TestBed _) {
-      var e = compile(_,
+    it('shoud register and handle event with long name', (TestBed _, Application app) {
+      var e = _.compile(
         '''<div foo>
-          <div on-my-new-event="ctrl.invoked=true;"></div>
+          <div on-my-new-event="ctrl.invoked=true"></div>
         </div>''');
+      document.body.append(app.element..append(e));
 
       _.triggerEvent(e.querySelector('[on-my-new-event]'), 'myNewEvent');
       var fooScope = _.getScope(e);
       expect(fooScope.context['ctrl'].invoked).toEqual(true);
     });
 
-    it('shoud have model updates applied correctly', (TestBed _) {
-      var e = compile(_,
+    it('should have model updates applied correctly', (TestBed _, Application app) {
+      var e = _.compile(
         '''<div foo>
-          <div on-abc='ctrl.description="new description";'>{{ctrl.description}}</div>
+          <div on-abc='ctrl.description="new description"'>{{ctrl.description}}</div>
         </div>''');
+      document.body.append(app.element..append(e));
       var el = document.querySelector('[on-abc]');
       el.dispatchEvent(new Event('abc'));
       _.rootScope.apply();
       expect(el.text).toEqual("new description");
     });
 
-    it('shoud register event when shadow dom is used', async((TestBed _) {
-      var e = compile(_,'<bar></bar>');
+    it('should register event when shadow dom is used', async((TestBed _, Application app) {
+      var e = _.compile('<bar></bar>');
+      document.body.append(app.element..append(e));
 
       microLeap();
 
@@ -89,13 +79,14 @@ main() {
       expect(ctrl.invoked).toEqual(true);
     }));
 
-    it('shoud handle event within content only once', async((TestBed _) {
-      var e = compile(_,
+    it('shoud handle event within content only once', async((TestBed _, Application app) {
+      var e = _.compile(
         '''<div foo>
              <bar>
                <div on-abc="ctrl.invoked=true;"></div>
              </bar>
            </div>''');
+      document.body.append(app.element..append(e));
 
       microLeap();