fix: prevent false positives for footer-leading-blank #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

marionebl merged 3 commits into master from fix/correct-footer-leading-blank-rule

May 1, 2017

Contributor

marionebl commented May 1, 2017

footer-leading-blank commonly produced false positives for empty footers
closes footer-leading-blank is complaining when there is no footer #13

marionebl added 3 commits

May 1, 2017 16:56


          test: add test cases for footer-leading-blank

d19d0e8


          fix: succeed footer-leading-blank if no footer is found

6b8f903


          fix: sanitize check for leading blank line before footer

5f7d611

marionebl merged commit 05b4427 into master

marionebl deleted the fix/correct-footer-leading-blank-rule branch

May 1, 2017 15:26

marionebl added a commit that referenced this pull request


          chore(release): v2.0.0

c78cece

<a name="2.0.0"></a>
# [2.0.0](v1.1.9...v2.0.0) (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this pull request


          chore(release): v2.1.0

c4ef509

<a name="2.1.0"></a>
# [2.1.0](v1.1.9...v2.1.0) (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this pull request


          fix: prevent false positives for footer-leading-blank (#33)

b51e2d0

* test: add test cases for footer-leading-blank

* fix: succeed footer-leading-blank if no footer is found

* fix: sanitize check for leading blank line before footer

marionebl added a commit that referenced this pull request


          chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…

3bd5829

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this pull request


          chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…

e1709ff

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this pull request


          fix: prevent false positives for footer-leading-blank (#33)

c821d32

* test: add test cases for footer-leading-blank

* fix: succeed footer-leading-blank if no footer is found

* fix: sanitize check for leading blank line before footer

marionebl added a commit that referenced this pull request


          chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…

9caa455

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this pull request


          chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…

5b24b2f

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this pull request


          fix: prevent false positives for footer-leading-blank (#33)

d58e421

* test: add test cases for footer-leading-blank

* fix: succeed footer-leading-blank if no footer is found

* fix: sanitize check for leading blank line before footer

marionebl added a commit that referenced this pull request


          chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…

fe53d35

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this pull request


          chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…

799cfc5

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this pull request


          fix: prevent false positives for footer-leading-blank (#33)

cc6098c

* test: add test cases for footer-leading-blank

* fix: succeed footer-leading-blank if no footer is found

* fix: sanitize check for leading blank line before footer

marionebl added a commit that referenced this pull request


          chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…

11504e1

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this pull request


          chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…

3044f69

… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

bpedersen pushed a commit to bpedersen/commitlint that referenced this pull request


          chore: 4.x fixes filter action flow (conventional-changelog#33)

f9da057

* chore: separates release workflow

* chore: separates release workflow

RosieBaish mentioned this pull request

Error message if colon is missed is highly misleading #3045

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet