Skip to content

fix: rebuff rules #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 77 commits into from
Jul 7, 2017
Merged

fix: rebuff rules #34

merged 77 commits into from
Jul 7, 2017

Conversation

marionebl
Copy link
Contributor

  • add tests for most rules
  • fix rule implementation if applicable

@marionebl marionebl force-pushed the fix/rebuff-footer-rules branch from 84a85fa to bcb383e Compare May 4, 2017 12:19
@marionebl marionebl force-pushed the fix/rebuff-footer-rules branch from bcb383e to 25c43f8 Compare May 4, 2017 12:22
@marionebl marionebl merged commit 702a2f7 into master Jul 7, 2017
@marionebl marionebl deleted the fix/rebuff-footer-rules branch July 7, 2017 11:53
marionebl added a commit that referenced this pull request Jul 7, 2017
<a name="2.0.0"></a>
# [2.0.0](v1.1.9...v2.0.0) (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
marionebl added a commit that referenced this pull request Jul 7, 2017
<a name="2.1.0"></a>
# [2.1.0](v1.1.9...v2.1.0) (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
marionebl added a commit that referenced this pull request Jul 7, 2017
* test: add test cases for footer-empty

* fix: finish footer-empty implementation

* test: add test cases for footer-max-length

* fix: allow empty footer for footer-max-length

* test: correct non-criticals in footer-max-length tests

* test: add test cases for footer-min-length

* fix: allow empty footer for footer-min-length

* test: add cases for body-empty

* fix: use keywords in body-empty

* test: add cases for subject-empty

* fix: use keywords in subject-empty

* test: add cases for type-empty

* test: remove superfluous message prefixes

* fix: use keywords in type-empty

* style: move tests into colocation

* test: add body-case test cases

* fix: handle empty body gracefully

* fix: rework ensure-case to produce saner output

* test: add cases for body-leading-blank

* test: add multiline body cases for footer-leading-blank

* fix: handle multiline bodies properly

* fix: harden body-leading-blank implementation

* test: add body-max-length cases

* fix: handle empty body gracefully

* test: add body-min-length cases

* fix: handle empty body gracefully

* fix: add test case for footer-tense

* feat: introduce object based config for footer-tense

* test: add header length tests

* test: add case rule tests

* fix: handle empty scope

* fix: handle empty subject

* style: harmonize case rules

* fix: handle empty type

* test: harmonize length tests

* test: add length tests

* chore: be specific about ava test files

* fix: implement length checks correctly

* chore: update dev dependencies

* test: add subject-full-stop cases

* fix: harden subject-full-stop implementation

* test: add case for subject-leading-capital

* fix: harden subject-leading-capital

* test: add body-tense case

* fix: harden body-tense rule

* fix: harden subject-tense

* test: add export case

* test: add case for lang

* chore: harden lang implementation

* chore: add missing devDependency

* chore: add nyc coverage

* test: add case for type-enum

* fix: harden type-enum

* test: add case for ensure-case

* chore: bring linting up to speed

* style: be consistent with xo

* test: add case for ensure-enum

* fix: harden ensure-enum

* test: add case for ensure-language

* test: add case for ensure-max-length

* test: add case for ensure-min-length

* test: add case for ensure-not-empty

* test: add case for ensure-tense

* fix: harden ensure tense against type errors

* chore: fix babel build on win32 platforms

* test: add test cases for execute-rule

* fix: handle noop calls gracefully

* test: add test cases for get-preset

* test: add test cases for format

* fix: more solid formatter implementation

* test: add shell tests for parse method

* fix: solidify and test resolve-extends

* test: execute color format test only if supported

* fix: harmonize dynamic importers

* chore: cleanup

* chore: do not babel test files

* chore: ignore *.test only for prod builds
marionebl added a commit that referenced this pull request Jul 7, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
marionebl added a commit that referenced this pull request Jul 7, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
marionebl added a commit that referenced this pull request Jul 10, 2017
* test: add test cases for footer-empty

* fix: finish footer-empty implementation

* test: add test cases for footer-max-length

* fix: allow empty footer for footer-max-length

* test: correct non-criticals in footer-max-length tests

* test: add test cases for footer-min-length

* fix: allow empty footer for footer-min-length

* test: add cases for body-empty

* fix: use keywords in body-empty

* test: add cases for subject-empty

* fix: use keywords in subject-empty

* test: add cases for type-empty

* test: remove superfluous message prefixes

* fix: use keywords in type-empty

* style: move tests into colocation

* test: add body-case test cases

* fix: handle empty body gracefully

* fix: rework ensure-case to produce saner output

* test: add cases for body-leading-blank

* test: add multiline body cases for footer-leading-blank

* fix: handle multiline bodies properly

* fix: harden body-leading-blank implementation

* test: add body-max-length cases

* fix: handle empty body gracefully

* test: add body-min-length cases

* fix: handle empty body gracefully

* fix: add test case for footer-tense

* feat: introduce object based config for footer-tense

* test: add header length tests

* test: add case rule tests

* fix: handle empty scope

* fix: handle empty subject

* style: harmonize case rules

* fix: handle empty type

* test: harmonize length tests

* test: add length tests

* chore: be specific about ava test files

* fix: implement length checks correctly

* chore: update dev dependencies

* test: add subject-full-stop cases

* fix: harden subject-full-stop implementation

* test: add case for subject-leading-capital

* fix: harden subject-leading-capital

* test: add body-tense case

* fix: harden body-tense rule

* fix: harden subject-tense

* test: add export case

* test: add case for lang

* chore: harden lang implementation

* chore: add missing devDependency

* chore: add nyc coverage

* test: add case for type-enum

* fix: harden type-enum

* test: add case for ensure-case

* chore: bring linting up to speed

* style: be consistent with xo

* test: add case for ensure-enum

* fix: harden ensure-enum

* test: add case for ensure-language

* test: add case for ensure-max-length

* test: add case for ensure-min-length

* test: add case for ensure-not-empty

* test: add case for ensure-tense

* fix: harden ensure tense against type errors

* chore: fix babel build on win32 platforms

* test: add test cases for execute-rule

* fix: handle noop calls gracefully

* test: add test cases for get-preset

* test: add test cases for format

* fix: more solid formatter implementation

* test: add shell tests for parse method

* fix: solidify and test resolve-extends

* test: execute color format test only if supported

* fix: harmonize dynamic importers

* chore: cleanup

* chore: do not babel test files

* chore: ignore *.test only for prod builds
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
marionebl added a commit that referenced this pull request Jul 10, 2017
* test: add test cases for footer-empty

* fix: finish footer-empty implementation

* test: add test cases for footer-max-length

* fix: allow empty footer for footer-max-length

* test: correct non-criticals in footer-max-length tests

* test: add test cases for footer-min-length

* fix: allow empty footer for footer-min-length

* test: add cases for body-empty

* fix: use keywords in body-empty

* test: add cases for subject-empty

* fix: use keywords in subject-empty

* test: add cases for type-empty

* test: remove superfluous message prefixes

* fix: use keywords in type-empty

* style: move tests into colocation

* test: add body-case test cases

* fix: handle empty body gracefully

* fix: rework ensure-case to produce saner output

* test: add cases for body-leading-blank

* test: add multiline body cases for footer-leading-blank

* fix: handle multiline bodies properly

* fix: harden body-leading-blank implementation

* test: add body-max-length cases

* fix: handle empty body gracefully

* test: add body-min-length cases

* fix: handle empty body gracefully

* fix: add test case for footer-tense

* feat: introduce object based config for footer-tense

* test: add header length tests

* test: add case rule tests

* fix: handle empty scope

* fix: handle empty subject

* style: harmonize case rules

* fix: handle empty type

* test: harmonize length tests

* test: add length tests

* chore: be specific about ava test files

* fix: implement length checks correctly

* chore: update dev dependencies

* test: add subject-full-stop cases

* fix: harden subject-full-stop implementation

* test: add case for subject-leading-capital

* fix: harden subject-leading-capital

* test: add body-tense case

* fix: harden body-tense rule

* fix: harden subject-tense

* test: add export case

* test: add case for lang

* chore: harden lang implementation

* chore: add missing devDependency

* chore: add nyc coverage

* test: add case for type-enum

* fix: harden type-enum

* test: add case for ensure-case

* chore: bring linting up to speed

* style: be consistent with xo

* test: add case for ensure-enum

* fix: harden ensure-enum

* test: add case for ensure-language

* test: add case for ensure-max-length

* test: add case for ensure-min-length

* test: add case for ensure-not-empty

* test: add case for ensure-tense

* fix: harden ensure tense against type errors

* chore: fix babel build on win32 platforms

* test: add test cases for execute-rule

* fix: handle noop calls gracefully

* test: add test cases for get-preset

* test: add test cases for format

* fix: more solid formatter implementation

* test: add shell tests for parse method

* fix: solidify and test resolve-extends

* test: execute color format test only if supported

* fix: harmonize dynamic importers

* chore: cleanup

* chore: do not babel test files

* chore: ignore *.test only for prod builds
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
marionebl added a commit that referenced this pull request Jul 11, 2017
* test: add test cases for footer-empty

* fix: finish footer-empty implementation

* test: add test cases for footer-max-length

* fix: allow empty footer for footer-max-length

* test: correct non-criticals in footer-max-length tests

* test: add test cases for footer-min-length

* fix: allow empty footer for footer-min-length

* test: add cases for body-empty

* fix: use keywords in body-empty

* test: add cases for subject-empty

* fix: use keywords in subject-empty

* test: add cases for type-empty

* test: remove superfluous message prefixes

* fix: use keywords in type-empty

* style: move tests into colocation

* test: add body-case test cases

* fix: handle empty body gracefully

* fix: rework ensure-case to produce saner output

* test: add cases for body-leading-blank

* test: add multiline body cases for footer-leading-blank

* fix: handle multiline bodies properly

* fix: harden body-leading-blank implementation

* test: add body-max-length cases

* fix: handle empty body gracefully

* test: add body-min-length cases

* fix: handle empty body gracefully

* fix: add test case for footer-tense

* feat: introduce object based config for footer-tense

* test: add header length tests

* test: add case rule tests

* fix: handle empty scope

* fix: handle empty subject

* style: harmonize case rules

* fix: handle empty type

* test: harmonize length tests

* test: add length tests

* chore: be specific about ava test files

* fix: implement length checks correctly

* chore: update dev dependencies

* test: add subject-full-stop cases

* fix: harden subject-full-stop implementation

* test: add case for subject-leading-capital

* fix: harden subject-leading-capital

* test: add body-tense case

* fix: harden body-tense rule

* fix: harden subject-tense

* test: add export case

* test: add case for lang

* chore: harden lang implementation

* chore: add missing devDependency

* chore: add nyc coverage

* test: add case for type-enum

* fix: harden type-enum

* test: add case for ensure-case

* chore: bring linting up to speed

* style: be consistent with xo

* test: add case for ensure-enum

* fix: harden ensure-enum

* test: add case for ensure-language

* test: add case for ensure-max-length

* test: add case for ensure-min-length

* test: add case for ensure-not-empty

* test: add case for ensure-tense

* fix: harden ensure tense against type errors

* chore: fix babel build on win32 platforms

* test: add test cases for execute-rule

* fix: handle noop calls gracefully

* test: add test cases for get-preset

* test: add test cases for format

* fix: more solid formatter implementation

* test: add shell tests for parse method

* fix: solidify and test resolve-extends

* test: execute color format test only if supported

* fix: harmonize dynamic importers

* chore: cleanup

* chore: do not babel test files

* chore: ignore *.test only for prod builds
marionebl added a commit that referenced this pull request Jul 11, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
marionebl added a commit that referenced this pull request Jul 11, 2017
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
bpedersen pushed a commit to bpedersen/commitlint that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant