-
Notifications
You must be signed in to change notification settings - Fork 934
footer-leading-blank is complaining when there is no footer #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm running into this issue as well, the footer isn't a requirement, is it? If it helps this error isn't thrown if you only have a subject and leave out the body and footer. However, when a body is included without a footer, this error seems to always get thrown. |
This issue is part of the roadmap to version 1 / a planned commitlint renamer. I'll pick it up as soon as possible, stay tuned. Thanks for the additional detail! |
@marionebl no problem, thanks for the awesome tool! Glad to hear you're actively working on the project. Side Note: Is there any way to ignore tense for certain patterns (e.g. with a regex or something)? If not, maybe I'll create another ticket with that as a feature request. For example, I have a package name that ends with -fetching and, when i mention in the commit subject, it throws a warning. (Arguably I should maybe rename that package, but I could definitely see this being useful in a variety of cases) |
@skipjack A feature request would be cool |
remove `conventional-changelog-lint` for now because of: * [footer-leading-blank is complaining when there is no footer · Issue #13 · marionebl/conventional-changelog-lint](conventional-changelog/commitlint#13)
ignore offending documentation module in .flow update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13 connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
ignore offending documentation module in .flow update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13 connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
ignore offending documentation module in .flow update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13 connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
ignore offending documentation module in .flow update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13 connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
When attempting to submit a commit:
I am getting:
There is no footer, therefore there must be no warning.
The text was updated successfully, but these errors were encountered: