Skip to content

footer-leading-blank is complaining when there is no footer #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gajus opened this issue Sep 1, 2016 · 4 comments · Fixed by #33
Closed

footer-leading-blank is complaining when there is no footer #13

gajus opened this issue Sep 1, 2016 · 4 comments · Fixed by #33
Labels

Comments

@gajus
Copy link

gajus commented Sep 1, 2016

When attempting to submit a commit:

chore: force add README.md
This is designed to be used in combination with .gitignore ./README.md when dynamically generating documentation.

I am getting:

⧗ input: chore: force add README.md
✖ footer must have leading blank line [footer-leading-blank]
⚠ tense of body must be present-imperative. Verbs in other tenses: is - present-third-person,generating - present-participle,starting - present-participle,is - present-third-person,commits - present-third-person,staged - > past-tense [body-tense]
⚠ header must not be shorter than 30 characters [header-min-length]
⚠ message must be lowerCase [subject-case]
✖ found 1 problems, 3 warnings

There is no footer, therefore there must be no warning.

@marionebl marionebl added the bug label Mar 6, 2017
@skipjack
Copy link

skipjack commented Apr 5, 2017

I'm running into this issue as well, the footer isn't a requirement, is it?

If it helps this error isn't thrown if you only have a subject and leave out the body and footer. However, when a body is included without a footer, this error seems to always get thrown.

@marionebl
Copy link
Contributor

This issue is part of the roadmap to version 1 / a planned commitlint renamer. I'll pick it up as soon as possible, stay tuned.

Thanks for the additional detail!

@skipjack
Copy link

skipjack commented Apr 5, 2017

@marionebl no problem, thanks for the awesome tool! Glad to hear you're actively working on the project.

Side Note: Is there any way to ignore tense for certain patterns (e.g. with a regex or something)? If not, maybe I'll create another ticket with that as a feature request. For example, I have a package name that ends with -fetching and, when i mention in the commit subject, it throws a warning. (Arguably I should maybe rename that package, but I could definitely see this being useful in a variety of cases)

@marionebl
Copy link
Contributor

@skipjack A feature request would be cool

whizark added a commit to devaloka/network-wp-query that referenced this issue Apr 9, 2017
remove `conventional-changelog-lint` for now because of:

* [footer-leading-blank is complaining when there is no footer · Issue #13 · marionebl/conventional-changelog-lint](conventional-changelog/commitlint#13)
craigmulligan referenced this issue in craigmulligan/gitinfo Jul 18, 2017
ignore offending documentation module in .flow
update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13

connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
craigmulligan referenced this issue in craigmulligan/gitinfo Jul 18, 2017
ignore offending documentation module in .flow
update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13

connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
craigmulligan referenced this issue in craigmulligan/gitinfo Jul 18, 2017
ignore offending documentation module in .flow
update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13

connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
craigmulligan referenced this issue in craigmulligan/gitinfo Jul 19, 2017
ignore offending documentation module in .flow
update conventional-changelog-lint to include https://github.com/marionebl/commitlint/issues/13

connects to broken build https://travis-ci.org/gajus/gitinfo/builds/254646852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants