make docker build working with after a fresh checkout

.dockerignore

@@ -1 +1,12 @@
+.git
+.gitignore
 Dockerfile
+lib
+node_modules
+**/dist
+**/out
+.DS_Store
+*.DS_Store
+release
+**/yarn-error.log
+**/node_modules

.gitignore

@@ -4,3 +4,4 @@ dist
 out
 .DS_Store
 release
+yarn-error.log

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:8.15.0
+FROM node:8.9.3
 
 # Install VS Code's deps. These are the only two it seems we need.
 RUN apt-get update && apt-get install -y \
@@ -18,7 +18,7 @@ RUN yarn && yarn task build:server:binary
 # We deploy with ubuntu so that devs have a familiar environemnt.
 FROM ubuntu:18.10
 WORKDIR /root/project
-COPY --from=0 /src/packages/server/cli-linux /usr/local/bin/code-server
+COPY --from=0 /src/packages/server/cli-linux-x64   /usr/local/bin/code-server
 EXPOSE 8443
 RUN apt-get update && apt-get install -y \
 	openssl \
@@ -29,4 +29,4 @@ RUN apt-get install -y locales && \
 # configured in /etc/default/locale so we need to set it manually.
 ENV LANG=en_US.UTF-8
 # Unfortunately `.` does not work with code-server.
-CMD code-server $PWD
+CMD code-server $PWD

build/tasks.ts

@@ -224,7 +224,7 @@ const ensureCloned = register("vscode:clone", async (runner) => {
 	}
 
 	runner.cwd = vscodePath;
-	const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]);
+	const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]); //TODO: this tag should come from a parameter
 	if (checkout.exitCode !== 0) {
 		throw new Error(`Failed to checkout: ${checkout.stderr}`);
 	}
@@ -235,6 +235,10 @@ const ensureClean = register("vscode:clean", async (runner) => {
 
 	const status = await runner.execute("git", ["status", "--porcelain"]);
 	if (status.stdout.trim() !== "") {
+
+		// inside docker this library throws error on git clean
+		await runner.execute("rm", ["-rf", "node_modules/spdlog"]);
+
 		const clean = await runner.execute("git", ["clean", "-f", "-d", "-X"]);
 		if (clean.exitCode !== 0) {
 			throw new Error(`Failed to clean git repository: ${clean.stderr}`);

package.json

@@ -6,8 +6,8 @@
   "description": "Run VS Code remotely.",
   "scripts": {
     "build:rules": "cd ./rules && tsc -p .",
-    "packages:install": "cd ./packages && yarn",
-    "postinstall": "npm-run-all --parallel packages:install build:rules",
+    "packages:install": "cd ./packages && yarn --frozen-lockfile",
+    "postinstall": "npm-run-all packages:install build:rules",
     "start": "cd ./packages/server && yarn start",
     "task": "ts-node -r tsconfig-paths/register build/tasks.ts",
     "test": "cd ./packages && yarn test"