Skip to content

Handle arch in dockerfile and add PR template #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Handle arch in dockerfile and add PR template #109

merged 2 commits into from
Mar 7, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Mar 7, 2019

No description provided.

@nhooyr nhooyr mentioned this pull request Mar 7, 2019
@kylecarbs kylecarbs merged commit 96175d3 into coder:master Mar 7, 2019
@nhooyr nhooyr deleted the docker branch March 7, 2019 21:51
andreimc added a commit to devonlineco/code-server that referenced this pull request Mar 11, 2019
* upstream/master: (35 commits)
  Dockerfile: use relative path instead of $PWD for CMD
  Update docker oneliner and fix clone task
  Clone exact vscode release branch when build task (coder#167)
  Add -t flag to docker example (coder#181)
  Reverts parts of my last PR (coder#177)
  Fix build and Dockerfile issues (coder#176)
  Add nginx reverse proxy guide for selfhosted
  Use a timing-safe equality check for passwords (coder#133)
  Open websocket on same path as page (coder#149)
  Adhere to XDG base directory spec for dataDir and logDir (coder#156)
  Improve github issue template (coder#162)
  Fix typo: environemnt -> environment (coder#159)
  Add back web class
  Move upx compression behind an env flag
  ci: enable travis npm cache (coder#110)
  Improve .dockerignore (coder#111)
  Feature/1.32.0 update (coder#117)
  Update grammar on README (coder#139)
  inital -> initial (coder#135)
  Handle arch in dockerfile and add PR template (coder#109)
  ...
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* repo: add a pull request template

* Dockerfile: include arch when copying

Thanks @yush1ga and @zerdos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants