make docker build working with after a fresh checkout #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Mar 7, 2019
| @@ -224,7 +224,7 @@ const ensureCloned = register("vscode:clone", async (runner) => { | |||
| } | |||
|
|
|||
| runner.cwd = vscodePath; | |||
| const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]); | |||
| const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]); //TODO: this tag should come from a parameter | |||
There was a problem hiding this comment.
What do you mean by a parameter?
There was a problem hiding this comment.
I guess he means it shouldn't be hard coded.
added 2 commits
March 7, 2019 20:23
nhooyr
reviewed
Mar 7, 2019
| @@ -1,4 +1,4 @@ | |||
| FROM node:8.15.0 | |||
| FROM node:8.9.3 | |||
nhooyr
reviewed
Mar 7, 2019
| @@ -18,7 +18,7 @@ RUN yarn && yarn task build:server:binary | |||
| # We deploy with ubuntu so that devs have a familiar environemnt. | |||
| FROM ubuntu:18.10 | |||
| WORKDIR /root/project | |||
| COPY --from=0 /src/packages/server/cli-linux /usr/local/bin/code-server | |||
| COPY --from=0 /src/packages/server/cli-linux-x64 /usr/local/bin/code-server | |||
There was a problem hiding this comment.
afaik, there shouldn't be a -x64 suffix?
There was a problem hiding this comment.
There should be - that is actually the only output
There was a problem hiding this comment.
Yup. This was recently changed without me knowing. It's fixed in #109.
|
I don't understand what this PR fixes. How does |
|
See #72 |
|
This PR makes the Dockerfile actually build without error :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.